Chromium Code Reviews| Index: Source/bindings/scripts/v8_methods.py |
| diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py |
| index 98db6c6d7bf62956a58a8e3809278df8fb554a22..e61f2a2a402b561f0a435877a826a4a1987e91e8 100644 |
| --- a/Source/bindings/scripts/v8_methods.py |
| +++ b/Source/bindings/scripts/v8_methods.py |
| @@ -119,7 +119,7 @@ def generate_method(interface, method): |
| is_raises_exception or |
| is_check_security_for_frame or |
| any(argument for argument in arguments |
| - if argument.idl_type.name in ('ByteString', 'SerializedScriptValue') or |
| + if argument.idl_type.name in ('ByteString', 'ScalarValueString', 'SerializedScriptValue') or |
|
Nils Barth (inactive)
2014/06/11 03:54:26
Could you wrap this line?
jsbell
2014/06/12 17:45:55
Done.
|
| argument.idl_type.is_integer_type), |
| 'is_call_with_execution_context': has_extended_attribute_value(method, 'CallWith', 'ExecutionContext'), |
| 'is_call_with_script_arguments': is_call_with_script_arguments, |
| @@ -286,7 +286,7 @@ def v8_value_to_local_cpp_value(argument, index): |
| if argument.is_variadic: |
| return v8_value_to_local_cpp_variadic_value(argument, index) |
| # [Default=NullString] |
| - if (argument.is_optional and idl_type.name == 'String' and |
| + if (argument.is_optional and idl_type.name in ('String', 'ByteString', 'ScalarValueString') and |
|
Nils Barth (inactive)
2014/06/11 03:54:26
Break/wrap?
jsbell
2014/06/12 17:45:55
Done.
|
| extended_attributes.get('Default') == 'NullString'): |
| v8_value = 'argumentOrNull(info, %s)' % index |
| else: |