Bindings: Add ScalarValueString support

Source/bindings/v8/V8Binding.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 477 matching lines @@
 
 float toFloat(v8::Handle<v8::Value> value, ExceptionState& exceptionState)
 {
     TONATIVE_DEFAULT_EXCEPTIONSTATE(v8::Local<v8::Number>, numberObject, value->ToNumber(), exceptionState, 0);
     return numberObject->NumberValue();
 }
 
 String toByteString(v8::Handle<v8::Value> value, ExceptionState& exceptionState)
 {
     // From the Web IDL spec: http://heycam.github.io/webidl/#es-ByteString
+    if (value.IsEmpty())
+        return String();
 
     // 1. Let x be ToString(v)
     TONATIVE_DEFAULT_EXCEPTIONSTATE(v8::Local<v8::String>, stringObject, value->ToString(), exceptionState, String());
     String x = toCoreString(stringObject);
 
     // 2. If the value of any element of x is greater than 255, then throw a TypeError.
     if (!x.containsOnlyLatin1()) {
         exceptionState.throwTypeError("Value is not a valid ByteString.");
         return String();
     }
 
     // 3. Return an IDL ByteString value whose length is the length of x, and where the
     // value of each element is the value of the corresponding element of x.
     // Blink: A ByteString is simply a String with a range constrained per the above, so
     // this is the identity operation.
     return x;
 }
 
+String toScalarValueString(v8::Handle<v8::Value> value, ExceptionState& exceptionState)
+{
+    // From the Encoding standard (with a TODO to move to Web IDL):
+    // http://encoding.spec.whatwg.org/#type-scalarvaluestring
+    if (value.IsEmpty())
+        return String();
+    TONATIVE_DEFAULT_EXCEPTIONSTATE(v8::Local<v8::String>, stringObject, value->ToString(), exceptionState, String());

[haraken, 2014/06/11 04:21:12]

Probably you can (or should?) use TOSTRING_DEFAULT.

[jsbell, 2014/06/12 17:45:55]

As discussed in the ByteString bug, I think we want to leave this as-is?

[haraken, 2014/06/12 17:49:02]

Yes!

+
+    // ScalarValueString is identical to DOMString except that "convert a
+    // DOMString to a sequence of Unicode characters" is used subsequently
+    // when converting to an IDL value
+    String x = toCoreString(stringObject);
+    return x.toScalarValueString();
+}
+
 PassRefPtrWillBeRawPtr<XPathNSResolver> toXPathNSResolver(v8::Handle<v8::Value> value, v8::Isolate* isolate)
 {
     RefPtrWillBeRawPtr<XPathNSResolver> resolver = nullptr;
     if (V8XPathNSResolver::hasInstance(value, isolate))
         resolver = V8XPathNSResolver::toNative(v8::Handle<v8::Object>::Cast(value));
     else if (value->IsObject())
         resolver = V8CustomXPathNSResolver::create(value->ToObject(), isolate);
     return resolver;
 }
 
@@ skipping 280 matching lines @@
 PassRefPtr<TraceEvent::ConvertableToTraceFormat> devToolsTraceEventData(ExecutionContext* context, v8::Handle<v8::Function> function, v8::Isolate* isolate)
 {
     int scriptId = 0;
     String resourceName;
     int lineNumber = 1;
     GetDevToolsFunctionInfo(function, isolate, scriptId, resourceName, lineNumber);
     return InspectorFunctionCallEvent::data(context, scriptId, resourceName, lineNumber);
 }
 
 } // namespace WebCore