Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 313983002: Add flag to enable experimental features for input view. (Closed)

Created:
6 years, 6 months ago by kevers
Modified:
6 years, 6 months ago
Reviewers:
miket_OOO, Shu Chen
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Add flag to enable experimental features for input view. BUG=380841 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275239

Patch Set 1 #

Patch Set 2 : Doc tweaks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/input/input.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/virtual_keyboard_private.json View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_switches.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_switches.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_util.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_util.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
kevers
Hi Shu, Can you please have a look at this CL.
6 years, 6 months ago (2014-06-04 20:35:55 UTC) #1
Shu Chen
lgtm What's the flag's default value?
6 years, 6 months ago (2014-06-05 00:19:11 UTC) #2
kevers
On 2014/06/05 00:19:11, Shu Chen wrote: > lgtm > > What's the flag's default value? ...
6 years, 6 months ago (2014-06-05 14:28:55 UTC) #3
kevers
+miket@ for extension OWNERS
6 years, 6 months ago (2014-06-05 14:35:10 UTC) #4
miket_OOO
c/b/e LGTM
6 years, 6 months ago (2014-06-05 15:43:53 UTC) #5
kevers
The CQ bit was checked by kevers@chromium.org
6 years, 6 months ago (2014-06-05 17:00:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/313983002/20001
6 years, 6 months ago (2014-06-05 17:03:23 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 19:49:08 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 21:11:07 UTC) #9
Message was sent while issue was closed.
Change committed as 275239

Powered by Google App Engine
This is Rietveld 408576698