Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 313963006: Missing return after class invalidation short-cut. (Closed)

Created:
6 years, 6 months ago by rune
Modified:
6 years, 6 months ago
Reviewers:
chrishtr, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Visibility:
Public.

Description

Missing return after class invalidation short-cut. scheduleStyleInvalidationForClassChange skipped comparison when oldClasses was empty, but forgot to return afterwards, causing invalidation sets to be scheduled twice. This fix increases runs/s by 10%+ on the added performance test. R=esprehn@chromium.org,chrishtr@chromium.org BUG=380874 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175568

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed stray comment and use the same property for all forced recalcs. #

Total comments: 2

Patch Set 3 : Use existing "root" element instead of creating a new one. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
A PerformanceTests/CSS/ClassInvalidation.html View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
rune
6 years, 6 months ago (2014-06-04 21:20:43 UTC) #1
rune
https://codereview.chromium.org/313963006/diff/1/PerformanceTests/CSS/ClassInvalidation.html File PerformanceTests/CSS/ClassInvalidation.html (right): https://codereview.chromium.org/313963006/diff/1/PerformanceTests/CSS/ClassInvalidation.html#newcode27 PerformanceTests/CSS/ClassInvalidation.html:27: // Modifying top on a static positioned, which should ...
6 years, 6 months ago (2014-06-04 21:23:14 UTC) #2
rune
https://codereview.chromium.org/313963006/diff/1/PerformanceTests/CSS/ClassInvalidation.html File PerformanceTests/CSS/ClassInvalidation.html (right): https://codereview.chromium.org/313963006/diff/1/PerformanceTests/CSS/ClassInvalidation.html#newcode27 PerformanceTests/CSS/ClassInvalidation.html:27: // Modifying top on a static positioned, which should ...
6 years, 6 months ago (2014-06-04 21:26:56 UTC) #3
rune
https://codereview.chromium.org/313963006/diff/20001/PerformanceTests/CSS/ClassInvalidation.html File PerformanceTests/CSS/ClassInvalidation.html (right): https://codereview.chromium.org/313963006/diff/20001/PerformanceTests/CSS/ClassInvalidation.html#newcode6 PerformanceTests/CSS/ClassInvalidation.html:6: <div id="root"></div> This is not in use. I must ...
6 years, 6 months ago (2014-06-04 22:42:39 UTC) #4
rune
https://codereview.chromium.org/313963006/diff/20001/PerformanceTests/CSS/ClassInvalidation.html File PerformanceTests/CSS/ClassInvalidation.html (right): https://codereview.chromium.org/313963006/diff/20001/PerformanceTests/CSS/ClassInvalidation.html#newcode6 PerformanceTests/CSS/ClassInvalidation.html:6: <div id="root"></div> On 2014/06/04 22:42:40, rune wrote: > > ...
6 years, 6 months ago (2014-06-04 22:44:52 UTC) #5
rune
PTAL
6 years, 6 months ago (2014-06-05 09:56:19 UTC) #6
esprehn
lgtm
6 years, 6 months ago (2014-06-05 10:31:55 UTC) #7
rune
The CQ bit was checked by rune@opera.com
6 years, 6 months ago (2014-06-05 10:34:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/313963006/40001
6 years, 6 months ago (2014-06-05 10:35:05 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-05 11:35:58 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 13:00:40 UTC) #11
Message was sent while issue was closed.
Change committed as 175568

Powered by Google App Engine
This is Rietveld 408576698