Issue 313963004: Don't delay loading if autoplay is set and preload equals 'none'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 313963004: Don't delay loading if autoplay is set and preload equals 'none'. (Closed)

Created:
6 years, 6 months ago by acolwell GONE FROM CHROMIUM

Modified:
6 years, 6 months ago

Reviewers:
adamk

CC:
blink-reviews, blink-reviews-html_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Don't delay loading if autoplay is set and preload equals 'none'. This fixes a regression that was accidentally introduced in r169669. If autoplay is set, then loading should not be delayed even if preload was set to "none". BUG=372770, 378682 TEST=LayoutTests/media/autoplay-with-preload-none.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175517

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -4 lines)			Patch
A +	LayoutTests/media/autoplay-with-preload-none.html	View	3 chunks	+3 lines, -3 lines	0 comments	Download
A	LayoutTests/media/autoplay-with-preload-none-expected.txt	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLMediaElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

The CQ bit was checked by acolwell@chromium.org

6 years, 6 months ago (2014-06-04 20:57:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/313963004/1

6 years, 6 months ago (2014-06-04 20:58:01 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...

6 years, 6 months ago (2014-06-04 21:19:44 UTC) #5

Message was sent while issue was closed.

Change committed as 175517

Expand Messages | Collapse Messages