Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 313933005: Add internal buckets for bootstrapping internal repos (Closed)

Created:
6 years, 6 months ago by hinoka
Modified:
6 years, 6 months ago
Reviewers:
Ryan Tseng, agable
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Add internal buckets for bootstrapping internal repos BUG=261741 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=274969

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use @properties #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M git_cache.py View 1 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Ryan Tseng
6 years, 6 months ago (2014-06-04 23:44:11 UTC) #1
agable
LGTM as long as permissions on chrome-git-whatever bucket are right. https://codereview.chromium.org/313933005/diff/1/git_cache.py File git_cache.py (right): https://codereview.chromium.org/313933005/diff/1/git_cache.py#newcode154 ...
6 years, 6 months ago (2014-06-05 00:45:27 UTC) #2
hinoka
The CQ bit was checked by hinoka@chromium.org
6 years, 6 months ago (2014-06-05 00:57:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@chromium.org/313933005/20001
6 years, 6 months ago (2014-06-05 00:58:10 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 01:00:08 UTC) #5
Message was sent while issue was closed.
Change committed as 274969

Powered by Google App Engine
This is Rietveld 408576698