Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: BUILD.gn

Issue 313923002: Fix building android gn (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 2caf0c0fc391a3f05ba65f7f8889acbb3dca1606..2fe4579f15e73e132de3f4f652642ec52f519229 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -976,8 +976,14 @@ executable("mksnapshot") {
":v8_nosnapshot",
]
+ libs = []
+
if (v8_compress_startup_data == "bz2") {
- libs = [ "bz2" ]
+ libs += [ "bz2" ]
+ }
+
+ if (is_android && current_toolchain != host_toolchain) {
+ libs += [ "log" ]
}
}
@@ -1004,10 +1010,6 @@ component("v8") {
]
}
- if (is_android && current_toolchain != host_toolchain) {
- libs = [ "log" ]
- }
-
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
configs += [ ":internal_config", ":features", ":toolchain" ]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698