Added "Look Up in Dictionary" item to context menu for Mac.

Added "Look Up in Dictionary" item to context menu for Mac. 

BUG=46153
TEST=manual

[gmorrita, 2010-08-11 11:36:10]

Hi Nico, could you take a time for this ?
This is  also a part of using-services series.
Thanks.

[Nico, 2010-08-19 21:51:42]

Sorry for the delay, I was on vacation.

LG from me with comments addressed. Pink is more familiar than me with this menu
stuff, so wait for a day or so if you hear complaints from him (if he chooses
not to comment, then go ahead and submit).

http://codereview.chromium.org/3139007/diff/1/4
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

http://codereview.chromium.org/3139007/diff/1/4#newcode401
chrome/browser/tab_contents/render_view_context_menu.cc:401: {
nit: brace goes on previous line.

also add a "// Used only in the Mac port." type of comment

http://codereview.chromium.org/3139007/diff/1/5
File chrome/browser/tab_contents/render_view_context_menu.h (right):

http://codereview.chromium.org/3139007/diff/1/5#newcode59
chrome/browser/tab_contents/render_view_context_menu.h:59: virtual void
LookupInDictionary();
Nit: "LookUpInDictionary"

http://codereview.chromium.org/3139007/diff/1/6
File chrome/browser/tab_contents/render_view_context_menu_mac.h (right):

http://codereview.chromium.org/3139007/diff/1/6#newcode12
chrome/browser/tab_contents/render_view_context_menu_mac.h:12: #include
"chrome/app/chrome_dll_resource.h"
not needed

http://codereview.chromium.org/3139007/diff/1/6#newcode14
chrome/browser/tab_contents/render_view_context_menu_mac.h:14: #include
"grit/generated_resources.h"
not needed either

Leave as many #includes out of .h files and put them into the .cc files instead.

http://codereview.chromium.org/3139007/diff/1/7
File chrome/browser/tab_contents/render_view_context_menu_mac.mm (right):

http://codereview.chromium.org/3139007/diff/1/7#newcode61
chrome/browser/tab_contents/render_view_context_menu_mac.mm:61: {
brace goes on previous line

http://codereview.chromium.org/3139007/diff/1/7#newcode74
chrome/browser/tab_contents/render_view_context_menu_mac.mm:74: {
likewise

http://codereview.chromium.org/3139007/diff/1/7#newcode75
chrome/browser/tab_contents/render_view_context_menu_mac.mm:75: //
FIXME(morrita): On Safari, A dictionary panel could be shown
s/FIXME/TODO/

http://codereview.chromium.org/3139007/diff/1/7#newcode80
chrome/browser/tab_contents/render_view_context_menu_mac.mm:80:
pboard([NSPasteboard pasteboardWithUniqueName]);
don't use a scoped_nsobject for this, pasteboardWithUniqueName returns an
autoreleased object. google "cocoa create rule"

[gmorrita, 2010-08-20 04:10:00]

Hi Nico, welcome back and thank you for reviewing!
I'd updated the path. 
I'll land this if there are no objections during a day.

http://codereview.chromium.org/3139007/diff/1/4
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

http://codereview.chromium.org/3139007/diff/1/4#newcode401
chrome/browser/tab_contents/render_view_context_menu.cc:401: {
On 2010/08/19 21:51:43, Nico wrote:
> nit: brace goes on previous line.
> 
> also add a "// Used only in the Mac port." type of comment

Done.

http://codereview.chromium.org/3139007/diff/1/5
File chrome/browser/tab_contents/render_view_context_menu.h (right):

http://codereview.chromium.org/3139007/diff/1/5#newcode59
chrome/browser/tab_contents/render_view_context_menu.h:59: virtual void
LookupInDictionary();
On 2010/08/19 21:51:43, Nico wrote:
> Nit: "LookUpInDictionary"

Done.

http://codereview.chromium.org/3139007/diff/1/6
File chrome/browser/tab_contents/render_view_context_menu_mac.h (right):

http://codereview.chromium.org/3139007/diff/1/6#newcode12
chrome/browser/tab_contents/render_view_context_menu_mac.h:12: #include
"chrome/app/chrome_dll_resource.h"
On 2010/08/19 21:51:43, Nico wrote:
> not needed

Done.

http://codereview.chromium.org/3139007/diff/1/6#newcode14
chrome/browser/tab_contents/render_view_context_menu_mac.h:14: #include
"grit/generated_resources.h"
On 2010/08/19 21:51:43, Nico wrote:
> not needed either
> 
> Leave as many #includes out of .h files and put them into the .cc files
instead.

Done.

http://codereview.chromium.org/3139007/diff/1/7
File chrome/browser/tab_contents/render_view_context_menu_mac.mm (right):

http://codereview.chromium.org/3139007/diff/1/7#newcode61
chrome/browser/tab_contents/render_view_context_menu_mac.mm:61: {
On 2010/08/19 21:51:43, Nico wrote:
> brace goes on previous line

Done.

http://codereview.chromium.org/3139007/diff/1/7#newcode74
chrome/browser/tab_contents/render_view_context_menu_mac.mm:74: {
On 2010/08/19 21:51:43, Nico wrote:
> likewise

Done.

http://codereview.chromium.org/3139007/diff/1/7#newcode75
chrome/browser/tab_contents/render_view_context_menu_mac.mm:75: //
FIXME(morrita): On Safari, A dictionary panel could be shown
On 2010/08/19 21:51:43, Nico wrote:
> s/FIXME/TODO/

Done.

http://codereview.chromium.org/3139007/diff/1/7#newcode80
chrome/browser/tab_contents/render_view_context_menu_mac.mm:80:
pboard([NSPasteboard pasteboardWithUniqueName]);
On 2010/08/19 21:51:43, Nico wrote:
> don't use a scoped_nsobject for this, pasteboardWithUniqueName returns an
> autoreleased object. google "cocoa create rule"

Done.

[tkent, 2010-08-23 04:10:32]

Committed as r57025.
http://crrev.com/57025