Split IndexedDBFactory into virtual base + impl.

content/browser/indexed_db/indexed_db_factory_impl.h

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_FACTORY_IMPL_H_
+#define CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_FACTORY_IMPL_H_
+
+#include "content/browser/indexed_db/indexed_db_factory.h"
+
+namespace content {
+
+class IndexedDBContextImpl;
+
+class CONTENT_EXPORT IndexedDBFactoryImpl : public IndexedDBFactory {
+ public:
+  explicit IndexedDBFactoryImpl(IndexedDBContextImpl* context);
+
+  virtual void ReleaseDatabase(const IndexedDBDatabase::Identifier& identifier,

[jochen (gone - plz use gerrit), 2014/07/15 11:44:46]

can you add an comment a la // IndexedDBFactory overrides

[cmumford, 2014/07/15 16:11:47]

Done.

+                               bool forcedClose) OVERRIDE;
+
+  virtual void GetDatabaseNames(
+      scoped_refptr<IndexedDBCallbacks> callbacks,
+      const GURL& origin_url,
+      const base::FilePath& data_directory,
+      net::URLRequestContext* request_context) OVERRIDE;
+  virtual void Open(const base::string16& name,
+                    const IndexedDBPendingConnection& connection,
+                    net::URLRequestContext* request_context,
+                    const GURL& origin_url,
+                    const base::FilePath& data_directory) OVERRIDE;
+
+  virtual void DeleteDatabase(const base::string16& name,
+                              net::URLRequestContext* request_context,
+                              scoped_refptr<IndexedDBCallbacks> callbacks,
+                              const GURL& origin_url,
+                              const base::FilePath& data_directory) OVERRIDE;
+
+  virtual void HandleBackingStoreFailure(const GURL& origin_url) OVERRIDE;
+  virtual void HandleBackingStoreCorruption(
+      const GURL& origin_url,
+      const IndexedDBDatabaseError& error) OVERRIDE;
+
+  virtual std::pair<OriginDBMapIterator, OriginDBMapIterator>
+      GetOpenDatabasesForOrigin(const GURL& origin_url) const OVERRIDE;
+
+  virtual void ForceClose(const GURL& origin_url) OVERRIDE;
+
+  // Called by the IndexedDBContext destructor so the factory can do cleanup.
+  virtual void ContextDestroyed() OVERRIDE;
+
+  // Called by the IndexedDBActiveBlobRegistry.
+  virtual void ReportOutstandingBlobs(const GURL& origin_url,
+                                      bool blobs_outstanding) OVERRIDE;
+
+  // Called by an IndexedDBDatabase when it is actually deleted.
+  virtual void DatabaseDeleted(
+      const IndexedDBDatabase::Identifier& identifier) OVERRIDE;
+
+  virtual size_t GetConnectionCount(const GURL& origin_url) const OVERRIDE;
+
+ protected:
+  virtual ~IndexedDBFactoryImpl();
+
+  virtual scoped_refptr<IndexedDBBackingStore> OpenBackingStore(
+      const GURL& origin_url,
+      const base::FilePath& data_directory,
+      net::URLRequestContext* request_context,
+      blink::WebIDBDataLoss* data_loss,
+      std::string* data_loss_reason,
+      bool* disk_full) OVERRIDE;
+
+  virtual scoped_refptr<IndexedDBBackingStore> OpenBackingStoreHelper(
+      const GURL& origin_url,
+      const base::FilePath& data_directory,
+      net::URLRequestContext* request_context,
+      blink::WebIDBDataLoss* data_loss,
+      std::string* data_loss_message,
+      bool* disk_full,
+      bool first_time) OVERRIDE;
+
+  void ReleaseBackingStore(const GURL& origin_url, bool immediate);
+  void CloseBackingStore(const GURL& origin_url);
+  IndexedDBContextImpl* context() const { return context_; }
+
+ private:
+  FRIEND_TEST_ALL_PREFIXES(IndexedDBFactoryTest,
+                           BackingStoreReleasedOnForcedClose);
+  FRIEND_TEST_ALL_PREFIXES(IndexedDBFactoryTest,
+                           BackingStoreReleaseDelayedOnClose);
+  FRIEND_TEST_ALL_PREFIXES(IndexedDBFactoryTest, DatabaseFailedOpen);
+  FRIEND_TEST_ALL_PREFIXES(IndexedDBFactoryTest,
+                           DeleteDatabaseClosesBackingStore);
+  FRIEND_TEST_ALL_PREFIXES(IndexedDBFactoryTest,
+                           ForceCloseReleasesBackingStore);
+  FRIEND_TEST_ALL_PREFIXES(IndexedDBFactoryTest,
+                           GetDatabaseNamesClosesBackingStore);
+
+  // Called internally after a database is closed, with some delay. If this
+  // factory has the last reference, it will be released.
+  void MaybeCloseBackingStore(const GURL& origin_url);
+  bool HasLastBackingStoreReference(const GURL& origin_url) const;
+
+  // Testing helpers, so unit tests don't need to grovel through internal state.
+  bool IsDatabaseOpen(const GURL& origin_url, const base::string16& name) const;
+  virtual bool IsBackingStoreOpen(const GURL& origin_url) const OVERRIDE;
+  bool IsBackingStorePendingClose(const GURL& origin_url) const;
+  void RemoveDatabaseFromMaps(const IndexedDBDatabase::Identifier& identifier);
+
+  DISALLOW_COPY_AND_ASSIGN(IndexedDBFactoryImpl);

[jochen (gone - plz use gerrit), 2014/07/15 11:44:46]

should go at the very end

[cmumford, 2014/07/15 16:11:47]

Done.

+
+  IndexedDBContextImpl* context_;
+
+  typedef std::map<IndexedDBDatabase::Identifier, IndexedDBDatabase*>
+      IndexedDBDatabaseMap;
+  IndexedDBDatabaseMap database_map_;
+  OriginDBMap origin_dbs_;
+
+  typedef std::map<GURL, scoped_refptr<IndexedDBBackingStore> >
+      IndexedDBBackingStoreMap;
+  IndexedDBBackingStoreMap backing_store_map_;
+
+  std::set<scoped_refptr<IndexedDBBackingStore> > session_only_backing_stores_;
+  IndexedDBBackingStoreMap backing_stores_with_active_blobs_;
+  std::set<GURL> backends_opened_since_boot_;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_FACTORY_IMPL_H_