Tools gdb script renamed class xrange to range for python3.0

Tools gdb script renamed class xrange to range for python3.0

Updated gdb script to use range instead of range.

R=hayato, jochen
BUG=380618
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175643

[hayato, 2014-06-05 03:28:38]

In general, I don't think using the same file for both 2 and 3 is a good idea.

For this particular change for xrange, I'd rather use just 'range' for both.
range and xrange have the different behavior in Python2, but the difference
isn't a big issue in this gdb script.

https://codereview.chromium.org/313833003/diff/1/Tools/gdb/webkit.py
File Tools/gdb/webkit.py (right):

https://codereview.chromium.org/313833003/diff/1/Tools/gdb/webkit.py#newcode46
Tools/gdb/webkit.py:46: def rangeHandler(start, end=0):
Th default value, end=0, looks strange to me.

If we call rangeHandler(10), that should be equal to range(10).
But the current code returns range(10, 0).

https://codereview.chromium.org/313833003/diff/1/Tools/gdb/webkit.py#newcode47
Tools/gdb/webkit.py:47: if sys.version < '3':
You should use sys.version_info.

https://codereview.chromium.org/313833003/diff/1/Tools/gdb/webkit.py#newcode50
Tools/gdb/webkit.py:50: return list(range(start, end))
This should be range(start, end)

[Habib Virji, 2014-06-05 08:59:57]

@hayato: Thanks for reviewing. 

I was not sure whether to create a separate file just for range handling as it
is small change. 

Let me know if to remove rangeHandler completely and replace it with range
instead of xrange.

https://codereview.chromium.org/313833003/diff/1/Tools/gdb/webkit.py
File Tools/gdb/webkit.py (right):

https://codereview.chromium.org/313833003/diff/1/Tools/gdb/webkit.py#newcode46
Tools/gdb/webkit.py:46: def rangeHandler(start, end=0):
On 2014/06/05 03:28:39, hayato wrote:
> Th default value, end=0, looks strange to me.
> 
> If we call rangeHandler(10), that should be equal to range(10).
> But the current code returns range(10, 0).

Done.

https://codereview.chromium.org/313833003/diff/1/Tools/gdb/webkit.py#newcode47
Tools/gdb/webkit.py:47: if sys.version < '3':
On 2014/06/05 03:28:39, hayato wrote:
> You should use sys.version_info.

Done.

https://codereview.chromium.org/313833003/diff/1/Tools/gdb/webkit.py#newcode50
Tools/gdb/webkit.py:50: return list(range(start, end))
On 2014/06/05 03:28:39, hayato wrote:
> This should be range(start, end)

Done.

[hayato, 2014-06-05 09:44:43]

> Let me know if to remove rangeHandler completely and replace it with range
instead of xrange.

Could you do that?
I think rangeHandler is not worth adding. Just using 'range' for both 2 & 3 is
good enough here, I think.

[Habib Virji, 2014-06-05 10:55:25]

On 2014/06/05 09:44:43, hayato wrote:
> > Let me know if to remove rangeHandler completely and replace it with range
> instead of xrange.
> 
> Could you do that?
> I think rangeHandler is not worth adding. Just using 'range' for both 2 & 3 is
> good enough here, I think.

Thanks hayato: Updated script. Please review.

[Habib Virji, 2014-06-05 10:56:35]

BTW tested with python 2 & 3, they appear to run okay with range instead of
xrange.

[hayato, 2014-06-06 00:39:06]

LGTM

[Habib Virji, 2014-06-06 03:35:55]

The CQ bit was checked by habib.virji@samsung.com

[commit-bot: I haz the power, 2014-06-06 03:36:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/habib.virji@samsung.com/313833003/40001

[commit-bot: I haz the power, 2014-06-06 04:38:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7100)

[commit-bot: I haz the power, 2014-06-06 04:41:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-06 04:41:03]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7103)

[jochen (gone - plz use gerrit), 2014-06-06 06:53:33]

lgtm

[Habib Virji, 2014-06-06 07:33:38]

The CQ bit was checked by habib.virji@samsung.com

[commit-bot: I haz the power, 2014-06-06 07:34:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/habib.virji@samsung.com/313833003/40001

[commit-bot: I haz the power, 2014-06-06 07:37:18]

Change committed as 175643