Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 313823004: Add assertHeld() to SkMutex. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tag some #

Patch Set 3 : notes #

Total comments: 2

Patch Set 4 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -46 lines) Patch
M include/core/SkThread.h View 1 2 3 2 chunks +9 lines, -2 lines 0 comments Download
M src/core/SkPaint.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkPixelRef.cpp View 1 chunk +19 lines, -19 lines 0 comments Download
M src/core/SkScaledImageCache.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pdf/SkPDFGraphicState.cpp View 1 2 3 3 chunks +5 lines, -7 lines 0 comments Download
M src/ports/SkMutex_pthread.h View 1 2 5 chunks +22 lines, -18 lines 0 comments Download
M src/ports/SkMutex_win.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
6 years, 6 months ago (2014-06-09 19:36:47 UTC) #1
bungeman-skia
lgtm
6 years, 6 months ago (2014-06-09 19:44:43 UTC) #2
mtklein
+reed for include/ !
6 years, 6 months ago (2014-06-09 19:45:26 UTC) #3
reed1
lgtm + documentation question https://codereview.chromium.org/313823004/diff/40001/include/core/SkThread.h File include/core/SkThread.h (right): https://codereview.chromium.org/313823004/diff/40001/include/core/SkThread.h#newcode88 include/core/SkThread.h:88: void assertHeld(); // Assert this ...
6 years, 6 months ago (2014-06-09 19:55:09 UTC) #4
mtklein
https://codereview.chromium.org/313823004/diff/40001/include/core/SkThread.h File include/core/SkThread.h (right): https://codereview.chromium.org/313823004/diff/40001/include/core/SkThread.h#newcode88 include/core/SkThread.h:88: void assertHeld(); // Assert this thread owns the mutex. ...
6 years, 6 months ago (2014-06-09 19:57:32 UTC) #5
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-09 19:57:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/313823004/60001
6 years, 6 months ago (2014-06-09 19:58:14 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 21:18:07 UTC) #8
Message was sent while issue was closed. 
Change committed as b83f6c3cbdabc14d8290b00d9f38ba59bf6719a1

Powered by Google App Engine
This is Rietveld 408576698