Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: Source/core/inspector/DOMEditor.cpp

Issue 313813002: Oilpan: Replace RefPtrs to Node and its subclasses in core/dom/ with Oilpan transtion types. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase and improvements Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLLinkElement.cpp ('k') | Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/DOMEditor.cpp
diff --git a/Source/core/inspector/DOMEditor.cpp b/Source/core/inspector/DOMEditor.cpp
index 24a80153d91cdfc156882f200dc12bf09143d527..b62682e8fe0036dce8d8dce6b7a5fbb54b841418 100644
--- a/Source/core/inspector/DOMEditor.cpp
+++ b/Source/core/inspector/DOMEditor.cpp
@@ -305,13 +305,17 @@ public:
virtual bool undo(ExceptionState& exceptionState) OVERRIDE
{
- m_parentNode->replaceChild(m_oldNode, m_newNode.get(), exceptionState);
+ // FIXME: Oilpan: The first .get() is unnecessary if m_oldNode is a
+ // Persistent or a Member.
+ m_parentNode->replaceChild(m_oldNode.get(), m_newNode.get(), exceptionState);
return !exceptionState.hadException();
}
virtual bool redo(ExceptionState& exceptionState) OVERRIDE
{
- m_parentNode->replaceChild(m_newNode, m_oldNode.get(), exceptionState);
+ // FIXME: Oilpan: The first .get() is unnecessary if m_newNode is a
+ // Persistent or a Member.
+ m_parentNode->replaceChild(m_newNode.get(), m_oldNode.get(), exceptionState);
return !exceptionState.hadException();
}
« no previous file with comments | « Source/core/html/HTMLLinkElement.cpp ('k') | Source/core/svg/SVGUseElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698