Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: Source/core/inspector/DOMEditor.cpp

Issue 313813002: Oilpan: Replace RefPtrs to Node and its subclasses in core/dom/ with Oilpan transtion types. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/DOMEditor.cpp
diff --git a/Source/core/inspector/DOMEditor.cpp b/Source/core/inspector/DOMEditor.cpp
index 24a80153d91cdfc156882f200dc12bf09143d527..80867f3ba72ddeeac9bb614bb5ae87cc8d358d4c 100644
--- a/Source/core/inspector/DOMEditor.cpp
+++ b/Source/core/inspector/DOMEditor.cpp
@@ -305,13 +305,23 @@ public:
virtual bool undo(ExceptionState& exceptionState) OVERRIDE
{
+#if ENABLE(OILPAN)
+ // FIXME: Oilpan: .get() is unnecessary if m_oldNode is Persistent or Member.
+ m_parentNode->replaceChild(m_oldNode.get(), m_newNode.get(), exceptionState);
+#else
m_parentNode->replaceChild(m_oldNode, m_newNode.get(), exceptionState);
zerny-chromium 2014/06/04 09:28:18 can't this just be .get() in both builds?
tkent 2014/06/05 00:22:27 ok, I add .get() and "FIXME: Oilpan" comment.
+#endif
return !exceptionState.hadException();
}
virtual bool redo(ExceptionState& exceptionState) OVERRIDE
{
+#if ENABLE(OILPAN)
+ // FIXME: Oilpan: .get() is unnecessary if m_oldNode is Persistent or Member.
+ m_parentNode->replaceChild(m_newNode.get(), m_oldNode.get(), exceptionState);
+#else
m_parentNode->replaceChild(m_newNode, m_oldNode.get(), exceptionState);
zerny-chromium 2014/06/04 09:28:18 ditto
+#endif
return !exceptionState.hadException();
}

Powered by Google App Engine
This is Rietveld 408576698