Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5154)

Unified Diff: chrome/service/cloud_print/print_system_win.cc

Issue 313723002: Convert local printer capabilites to CDD format to unify with cloud printers and PDF printer. This … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/cloud_print/print_system_win.cc
diff --git a/chrome/service/cloud_print/print_system_win.cc b/chrome/service/cloud_print/print_system_win.cc
index 98a4e97880e342a5b8546699a63e0ca9f6484ba3..6e5603671638d59a477b7533d1faf81efbc6ffc2 100644
--- a/chrome/service/cloud_print/print_system_win.cc
+++ b/chrome/service/cloud_print/print_system_win.cc
@@ -6,6 +6,7 @@
#include "base/command_line.h"
#include "base/file_util.h"
+#include "base/json/json_writer.h"
#include "base/memory/scoped_ptr.h"
#include "base/strings/utf_string_conversions.h"
#include "base/win/object_watcher.h"
@@ -13,6 +14,7 @@
#include "base/win/scoped_comptr.h"
#include "base/win/scoped_hdc.h"
#include "chrome/common/chrome_switches.h"
+#include "chrome/common/cloud_print/cloud_print_cdd_conversion.h"
#include "chrome/common/cloud_print/cloud_print_constants.h"
#include "chrome/common/crash_keys.h"
#include "chrome/service/cloud_print/cdd_conversion_win.h"
@@ -565,7 +567,11 @@ class PrinterCapsHandler : public ServiceUtilityProcessHost::Client {
printing::PrinterCapsAndDefaults printer_info;
if (succeeded) {
printer_info.caps_mime_type = kContentTypeJSON;
- printer_info.printer_capabilities = CapabilitiesToCdd(semantic_info);
+ scoped_ptr<base::DictionaryValue> description(
+ PrinterSemanticCapsAndDefaultsToCdd(semantic_info));
+ base::JSONWriter::WriteWithOptions(
Vitaly Buka (NO REVIEWS) 2014/06/04 00:05:46 empty string?
Aleksey Shlyapnikov 2014/06/04 02:02:47 Done.
+ description.get(), base::JSONWriter::OPTIONS_PRETTY_PRINT,
+ &printer_info.printer_capabilities);
}
callback_.Run(succeeded, printer_name, printer_info);
callback_.Reset();

Powered by Google App Engine
This is Rietveld 408576698