Issue 3137040: GTTF: Extract performance-testing-specific parts of UITestBase to UIPerfTest....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3137040: GTTF: Extract performance-testing-specific parts of UITestBase to UIPerfTest.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by Paweł Hajdan Jr.

Modified:
4 years ago

Reviewers:
huanr, jar (doing other things), viettrungluu

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

GTTF: Extract performance-testing-specific parts of UITestBase to UIPerfTest. In the future this may even be used to tune some settings/behaviors (like timeouts) for performance tests. TEST=ui_tests, page_cycler_*, etc BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57552

Patch Set 1 #

Patch Set 2 : '' #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -2213 lines)			Patch
M	chrome/chrome_tests.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/test/memory_test/memory_test.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/page_cycler/page_cycler_test.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/startup/feature_startup_test.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/startup/shutdown_test.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/startup/startup_test.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/tab_switching/tab_switching_test.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/ui/dromaeo_benchmark_uitest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/ui/sunspider_uitest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	chrome/test/ui/ui_perf_test.h	View	4 chunks	+5 lines, -568 lines	0 comments	Download
A +	chrome/test/ui/ui_perf_test.cc	View	9 chunks	+10 lines, -1233 lines	0 comments	Download
M	chrome/test/ui/ui_test.h	View	3 chunks	+0 lines, -74 lines	0 comments	Download
M	chrome/test/ui/ui_test.cc	View	2 chunks	+0 lines, -316 lines	0 comments	Download
M	chrome/test/ui/v8_benchmark_uitest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome_frame/test/perf/chrome_frame_perftest.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Trybot results: mac linux win

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nice! LGTM, assuming green trybots and all that.

Expand Messages | Collapse Messages