Chromium Code Reviews
Help | Chromium Project | Sign in
(696)

Issue 3137040: GTTF: Extract performance-testing-specific parts of UITestBase to UIPerfTest.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Paweł Hajdan Jr.
Modified:
4 years ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

GTTF: Extract performance-testing-specific parts of UITestBase to UIPerfTest. In the future this may even be used to tune some settings/behaviors (like timeouts) for performance tests. TEST=ui_tests, page_cycler_*, etc BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57552

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2213 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/memory_test/memory_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/page_cycler/page_cycler_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/startup/feature_startup_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/startup/shutdown_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/startup/startup_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/tab_switching/tab_switching_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/ui/dromaeo_benchmark_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/ui/sunspider_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/test/ui/ui_perf_test.h View 4 chunks +5 lines, -568 lines 0 comments Download
A + chrome/test/ui/ui_perf_test.cc View 9 chunks +10 lines, -1233 lines 0 comments Download
M chrome/test/ui/ui_test.h View 3 chunks +0 lines, -74 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 2 chunks +0 lines, -316 lines 0 comments Download
M chrome/test/ui/v8_benchmark_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
I used svn cp to preserve metadata.
4 years, 9 months ago (2010-08-25 23:24:26 UTC) #1
viettrungluu
4 years, 9 months ago (2010-08-25 23:29:50 UTC) #2
Nice! LGTM, assuming green trybots and all that.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be