Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1138)

Unified Diff: chrome/test/ui/ui_test.h

Issue 3137040: GTTF: Extract performance-testing-specific parts of UITestBase to UIPerfTest.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/ui/ui_perf_test.cc ('k') | chrome/test/ui/ui_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/ui/ui_test.h
===================================================================
--- chrome/test/ui/ui_test.h (revision 57402)
+++ chrome/test/ui/ui_test.h (working copy)
@@ -234,56 +234,6 @@
// after the browser process has terminated.
bool CloseBrowser(BrowserProxy* browser, bool* application_closed) const;
- // Prints numerical information to stdout in a controlled format, for
- // post-processing. |measurement| is a description of the quantity being
- // measured, e.g. "vm_peak"; |modifier| is provided as a convenience and
- // will be appended directly to the name of the |measurement|, e.g.
- // "_browser"; |trace| is a description of the particular data point, e.g.
- // "reference"; |value| is the measured value; and |units| is a description
- // of the units of measure, e.g. "bytes". If |important| is true, the output
- // line will be specially marked, to notify the post-processor. The strings
- // may be empty. They should not contain any colons (:) or equals signs (=).
- // A typical post-processing step would be to produce graphs of the data
- // produced for various builds, using the combined |measurement| + |modifier|
- // string to specify a particular graph and the |trace| to identify a trace
- // (i.e., data series) on that graph.
- void PrintResult(const std::string& measurement,
- const std::string& modifier,
- const std::string& trace,
- size_t value,
- const std::string& units,
- bool important);
-
- // Like the above version of PrintResult(), but takes a std::string value
- // instead of a size_t.
- void PrintResult(const std::string& measurement,
- const std::string& modifier,
- const std::string& trace,
- const std::string& value,
- const std::string& units,
- bool important);
-
- // Like PrintResult(), but prints a (mean, standard deviation) result pair.
- // The |<values>| should be two comma-seaprated numbers, the mean and
- // standard deviation (or other error metric) of the measurement.
- void PrintResultMeanAndError(const std::string& measurement,
- const std::string& modifier,
- const std::string& trace,
- const std::string& mean_and_error,
- const std::string& units,
- bool important);
-
- // Like PrintResult(), but prints an entire list of results. The |values|
- // will generally be a list of comma-separated numbers. A typical
- // post-processing step might produce plots of their mean and standard
- // deviation.
- void PrintResultList(const std::string& measurement,
- const std::string& modifier,
- const std::string& trace,
- const std::string& values,
- const std::string& units,
- bool important);
-
// Gets the directory for the currently active profile in the browser.
FilePath GetDownloadDirectory();
@@ -491,20 +441,6 @@
void StopHttpServer();
- // Prints IO performance data for use by perf graphs.
- void PrintIOPerfInfo(const char* test_name);
-
- // Prints memory usage data for use by perf graphs.
- void PrintMemoryUsageInfo(const char* test_name);
-
- // Prints memory commit charge stats for use by perf graphs.
- void PrintSystemCommitCharge(const char* test_name,
- size_t charge,
- bool important);
-
- // Configures the test to use the reference build.
- void UseReferenceBuild();
-
// Use Chromium binaries from the given directory.
void SetBrowserDirectory(const FilePath& dir);
@@ -513,16 +449,6 @@
// the given message if any do.
void AssertAppNotRunning(const std::wstring& error_message);
- // Common functionality for the public PrintResults methods.
- void PrintResultsImpl(const std::string& measurement,
- const std::string& modifier,
- const std::string& trace,
- const std::string& values,
- const std::string& prefix,
- const std::string& suffix,
- const std::string& units,
- bool important);
-
protected:
AutomationProxy* automation() {
EXPECT_TRUE(server_.get());
« no previous file with comments | « chrome/test/ui/ui_perf_test.cc ('k') | chrome/test/ui/ui_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698