Expand GPU rasterization device whitelist for Finch experiment

Expand GPU rasterization device whitelist for field trial

This creates an expanded GPU rasterization device whitelist
for a field trial.

BUG=380694
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275572

[vangelis, 2014-06-05 06:06:56]

I would avoid using the word Finch (as that's an internal codename) and stick
with field trial. 

One comment but looks good otherwise.

https://codereview.chromium.org/313703002/diff/30001/gpu/config/software_rend...
File gpu/config/software_rendering_list_json.cc (right):

https://codereview.chromium.org/313703002/diff/30001/gpu/config/software_rend...
gpu/config/software_rendering_list_json.cc:1184: "machine_model_name": ["Nexus
4", "Nexus 5", "Nexus 7",
Could this entry only contain the devices that are not in #96 and the logic in
IsGpuRasterizationBlacklisted be adjusted accordingly? That way when we can keep
expanding the fixed list of whitelisted devices without having to add them to
both 96 and 97.

[ajuma, 2014-06-05 14:20:29]

https://codereview.chromium.org/313703002/diff/30001/gpu/config/software_rend...
File gpu/config/software_rendering_list_json.cc (right):

https://codereview.chromium.org/313703002/diff/30001/gpu/config/software_rend...
gpu/config/software_rendering_list_json.cc:1184: "machine_model_name": ["Nexus
4", "Nexus 5", "Nexus 7",
On 2014/06/05 06:06:56, vangelis wrote:
> Could this entry only contain the devices that are not in #96 and the logic in
> IsGpuRasterizationBlacklisted be adjusted accordingly? That way when we can
keep
> expanding the fixed list of whitelisted devices without having to add them to
> both 96 and 97. 

Good idea, done.

[Vangelis Kokkevis, 2014-06-05 16:15:39]

lgtm

[ajuma, 2014-06-06 14:07:23]

zmo@, PTAL.

[Zhenyao Mo, 2014-06-06 21:42:38]

On 2014/06/06 14:07:23, ajuma wrote:
> zmo@, PTAL.

LGTM

That's the weirdest use of blacklisting I've ever seen.

[ajuma, 2014-06-06 22:23:17]

The CQ bit was checked by ajuma@chromium.org

[commit-bot: I haz the power, 2014-06-06 22:25:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ajuma@chromium.org/313703002/50001

[commit-bot: I haz the power, 2014-06-07 00:24:08]

Change committed as 275572