Issue 3137007: Uncrashy TaskManagerBrowserTest.PopulateWebCacheFields

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3137007: Uncrashy TaskManagerBrowserTest.PopulateWebCacheFields (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by Paweł Hajdan Jr.

Modified:
4 years ago

Reviewers:
jamesr, Jay Civelli, James Hawkins

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Visibility:
Public.

Description

Uncrashy TaskManagerBrowserTest.PopulateWebCacheFields This doesn't really solve the problem, but I have tried before and failed. DISABLED -> FLAKY is still an improvement, and it could also help with other disabled TaskManager tests. TEST=browser_tests BUG=42301

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	chrome/browser/task_manager.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/task_manager_browsertest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Trybot results: linux win mac

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

rubber-stamp LGTM. Who wrote this class originally?

4 years, 9 months ago (2010-08-12 22:52:54 UTC) #2

LGTM

Expand Messages | Collapse Messages