Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 3137007: Uncrashy TaskManagerBrowserTest.PopulateWebCacheFields (Closed)

Created:
10 years, 4 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org
Visibility:
Public.

Description

Uncrashy TaskManagerBrowserTest.PopulateWebCacheFields This doesn't really solve the problem, but I have tried before and failed. DISABLED -> FLAKY is still an improvement, and it could also help with other disabled TaskManager tests. TEST=browser_tests BUG=42301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/task_manager.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/task_manager_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
10 years, 4 months ago (2010-08-12 22:48:33 UTC) #1
James Hawkins
rubber-stamp LGTM. Who wrote this class originally?
10 years, 4 months ago (2010-08-12 22:52:54 UTC) #2
Jay Civelli
10 years, 4 months ago (2010-08-12 23:13:20 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698