Issue 313653006: Return NULL when building empty LayerRasterizer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 313653006: Return NULL when building empty LayerRasterizer. (Closed)

Created:
6 years, 6 months ago by scroggo

Modified:
6 years, 6 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Return NULL when building empty LayerRasterizer. In SkLayerRasterizer::snapshotRasterizer() and ::detachRasterizer(), if no layers have been added, do not attempt to create an SkLayerRasterizer. Instead, return NULL. This fixes an error when running tests on Android. Update dox to state that NULL may be returned. Add tests. Committed: https://skia.googlesource.com/skia/+/65044bfe021e9c0023d78080583e9acb3bdb5ce7

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -5 lines)			Patch
M	include/effects/SkLayerRasterizer.h	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/effects/SkLayerRasterizer.cpp	View	1 chunk	+10 lines, -1 line	0 comments	Download
M	tests/LayerRasterizerTest.cpp	View	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/313653006/1

6 years, 6 months ago (2014-06-03 19:48:14 UTC) #4

commit-bot: I haz the power

6 years, 6 months ago (2014-06-03 20:12:55 UTC) #5

Message was sent while issue was closed.

Change committed as 65044bfe021e9c0023d78080583e9acb3bdb5ce7

Expand Messages | Collapse Messages