Issue 313653005: Mojo: Add an extremely skeletal mojo_shell_tests.

Issue 313653005: Mojo: Add an extremely skeletal mojo_shell_tests. (Closed)

Created:
6 years, 6 months ago by viettrungluu

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Add an extremely skeletal mojo_shell_tests. For now, I'm just testing ChildProcess/ChildProcessHost (turned the "manual" test code into a proper automated test). I'll add an app-loading test shortly. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274692

Patch Set 1 #

Patch Set 2 : git cl upload crashed #

Total comments: 2

Patch Set 3 : get rid of extraneous mojo::(shell::)s #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -46 lines)			Patch
M	mojo/mojo.gyp	View		2 chunks	+24 lines, -0 lines	0 comments	Download
A	mojo/shell/child_process_host_unittest.cc	View	1 2	1 chunk	+56 lines, -0 lines	0 comments	Download
M	mojo/shell/desktop/mojo_main.cc	View		1 chunk	+0 lines, -39 lines	0 comments	Download
A	mojo/shell/shell_test_base.h	View	1 2	1 chunk	+33 lines, -0 lines	0 comments	Download
A +	mojo/shell/shell_test_base.cc	View		1 chunk	+9 lines, -7 lines	0 comments	Download
A	mojo/shell/shell_test_main.cc	View		1 chunk	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/313653005/diff/20001/mojo/shell/child_process_host_unittest.cc File mojo/shell/child_process_host_unittest.cc (right): https://codereview.chromium.org/313653005/diff/20001/mojo/shell/child_process_host_unittest.cc#newcode23 mojo/shell/child_process_host_unittest.cc:23: : public mojo::shell::ChildProcessHost::Delegate { nit: Do you really ...

6 years, 6 months ago (2014-06-03 18:20:51 UTC) #2

viettrungluu

Thanks. https://codereview.chromium.org/313653005/diff/20001/mojo/shell/child_process_host_unittest.cc File mojo/shell/child_process_host_unittest.cc (right): https://codereview.chromium.org/313653005/diff/20001/mojo/shell/child_process_host_unittest.cc#newcode23 mojo/shell/child_process_host_unittest.cc:23: : public mojo::shell::ChildProcessHost::Delegate { On 2014/06/03 18:20:51, sky ...

6 years, 6 months ago (2014-06-03 19:11:50 UTC) #3

viettrungluu

6 years, 6 months ago (2014-06-04 01:03:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r274692 (presubmit successful).

Expand Messages | Collapse Messages