Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 313653004: Fix composited bounds of reflections. (Closed)

Created:
6 years, 6 months ago by chrishtr
Modified:
6 years, 6 months ago
Reviewers:
ojan
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Visibility:
Public.

Description

Fix composited bounds of reflections. Previously, they were not taking into account child stacking contexts of the layer being reflected. BUG=372837 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175432

Patch Set 1 #

Patch Set 2 : Fix. #

Patch Set 3 : Fix. #

Patch Set 4 : Fix #

Total comments: 2

Patch Set 5 : Added static. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M Source/core/rendering/RenderLayer.cpp View 1 2 3 4 2 chunks +24 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
chrishtr
This bug was revealed during refactoring of graphics layers to replace anchorPoint with transformOrigin. The ...
6 years, 6 months ago (2014-06-03 18:02:22 UTC) #1
ojan
lgtm https://codereview.chromium.org/313653004/diff/60001/Source/core/rendering/RenderLayer.cpp File Source/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/313653004/diff/60001/Source/core/rendering/RenderLayer.cpp#newcode3341 Source/core/rendering/RenderLayer.cpp:3341: void expandCompositingRectForStackingChildren(const RenderLayer* ancestorLayer, RenderLayer::CalculateBoundsOptions options, LayoutRect& result) ...
6 years, 6 months ago (2014-06-03 23:59:38 UTC) #2
chrishtr
https://codereview.chromium.org/313653004/diff/60001/Source/core/rendering/RenderLayer.cpp File Source/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/313653004/diff/60001/Source/core/rendering/RenderLayer.cpp#newcode3341 Source/core/rendering/RenderLayer.cpp:3341: void expandCompositingRectForStackingChildren(const RenderLayer* ancestorLayer, RenderLayer::CalculateBoundsOptions options, LayoutRect& result) On ...
6 years, 6 months ago (2014-06-04 00:01:39 UTC) #3
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 6 months ago (2014-06-04 00:04:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/313653004/70001
6 years, 6 months ago (2014-06-04 00:04:20 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 03:03:10 UTC) #6
Message was sent while issue was closed.
Change committed as 175432

Powered by Google App Engine
This is Rietveld 408576698