Chromium Code Reviews Chromium Code Reviews
Issue
313633003:
Revert 274549 "Add generateAppForLink function in chrome.management" (Closed)
DescriptionRevert 274549 "Add generateAppForLink function in chrome.management"
Broke BookmarkAppHelperExtensionServiceTest.CreateBookmarkApp on Linux Clang (dbg) and other bots:
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Clang%20%28dbg%29&number=60356
[ RUN ] BookmarkAppHelperExtensionServiceTest.CreateBookmarkApp
[26813:26813:0603/095344:697268828:FATAL:render_process_host_impl.cc(501)] Check failed: is_self_deleted_. RenderProcessHostImpl is destroyed by something other than itself
#0 0x7fb30098e8de base::debug::StackTrace::StackTrace()
#1 0x7fb300a21b85 logging::LogMessage::~LogMessage()
#2 0x7fb308595006 content::RenderProcessHostImpl::~RenderProcessHostImpl()
#3 0x7fb3085955a9 content::RenderProcessHostImpl::~RenderProcessHostImpl()
#4 0x000000eef1df (anonymous namespace)::BookmarkAppHelperExtensionServiceTest::TearDown()
#5 0x0000039dd3c3 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>()
#6 0x0000039ca68e testing::internal::HandleExceptionsInMethodIfSupported\u003C>()
#7 0x0000039c159a testing::Test::Run()
#8 0x0000039c1c6b testing::TestInfo::Run()
#9 0x0000039c225a testing::TestCase::Run()
#10 0x0000039c6868 testing::internal::UnitTestImpl::RunAllTests()
#11 0x0000039d60d3 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>()
#12 0x0000039cc26e testing::internal::HandleExceptionsInMethodIfSupported\u003C>()
#13 0x0000039c64f4 testing::UnitTest::Run()
#14 0x00000594af51 RUN_ALL_TESTS()
#15 0x000005949ff7 base::TestSuite::Run()
#16 0x00000595dc4d content::UnitTestTestSuite::Run()
#17 0x000003a80772 base::internal::RunnableAdapter\u003C>::Run()
#18 0x000003a806dc base::internal::InvokeHelper\u003C>::MakeItSo()
#19 0x000003a8068a base::internal::Invoker\u003C>::Run()
#20 0x000002b6f0de base::Callback\u003C>::Run()
#21 0x00000594404e base::(anonymous namespace)::LaunchUnitTestsInternal()
#22 0x000005943d40 base::LaunchUnitTests()
#23 0x000003a80450 main
#24 0x7fb2f7c6076d __libc_start_main
#25 0x000000710379 \u003Cunknown>
> Add generateAppForLink function in chrome.management
>
> This function takes a url and a title as input, generates and
> returns a bookmark app.
>
> R=benwells@chromium.org,kalman@chromium.org,calamity@chromium.org
> BUG=370350
>
> Review URL: https://codereview.chromium.org/266353006
TBR=wjywbs@gmail.com
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274556
Patch Set 1 #Messages
Total messages: 3 (0 generated)
|
