Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 313623003: WIP: Option2: Android media: VideoFrame should not store so many sync points. (Closed)

Created:
6 years, 6 months ago by dshwang
Modified:
6 years, 6 months ago
Reviewers:
CC:
chromium-reviews, fischman+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

WIP: Option2: Android media: VideoFrame should not store so many sync points. VideoFrame keeps sync points via Map, not Vector. The key is the origin of clients. So VideoFrame can keep only one sync point per client. BUG=350925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -69 lines) Patch
M cc/resources/video_resource_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 5 chunks +21 lines, -11 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/common/media/video_capture_messages.h View 1 chunk +4 lines, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +5 lines, -1 line 0 comments Download
M content/renderer/media/rtc_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M content/renderer/media/video_capture_impl.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/media/video_capture_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/video_capture_impl_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/media/video_capture_message_filter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 1 chunk +5 lines, -1 line 0 comments Download
M media/base/video_frame.h View 4 chunks +9 lines, -6 lines 0 comments Download
M media/base/video_frame.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/base/video_frame_unittest.cc View 3 chunks +28 lines, -14 lines 0 comments Download
M media/filters/gpu_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dshwang
6 years, 6 months ago (2014-06-05 14:40:11 UTC) #1 
https://codereview.chromium.org/312803002/ choose this option. so this reference
impl is applied to the CL.
I close this duplicated CL.

Powered by Google App Engine
This is Rietveld 408576698