Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: tools/PictureRenderer.cpp

Issue 313613004: Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer) (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Add staging entry point for Chromium and Android Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/PictureRenderer.cpp
diff --git a/tools/PictureRenderer.cpp b/tools/PictureRenderer.cpp
index 5128782d4400a37fcbda7e98b8282c237f0d1c3c..0343460e3205bd6ed8901bc9d7acf9496ab05de9 100644
--- a/tools/PictureRenderer.cpp
+++ b/tools/PictureRenderer.cpp
@@ -390,7 +390,7 @@ bool PipePictureRenderer::render(SkBitmap** out) {
PipeController pipeController(fCanvas.get());
SkGPipeWriter writer;
SkCanvas* pipeCanvas = writer.startRecording(&pipeController);
- pipeCanvas->drawPicture(*fPicture);
+ pipeCanvas->drawPicture(fPicture);
writer.endRecording();
fCanvas->flush();
if (NULL != out) {
@@ -426,7 +426,7 @@ bool SimplePictureRenderer::render(SkBitmap** out) {
return false;
}
- fCanvas->drawPicture(*fPicture);
+ fCanvas->drawPicture(fPicture);
fCanvas->flush();
if (NULL != out) {
*out = SkNEW(SkBitmap);
@@ -592,7 +592,7 @@ static void draw_tile_to_canvas(SkCanvas* canvas, const SkRect& tileRect, SkPict
SkMatrix mat(canvas->getTotalMatrix());
mat.postTranslate(-tileRect.fLeft, -tileRect.fTop);
canvas->setMatrix(mat);
- canvas->drawPicture(*picture);
+ canvas->drawPicture(picture);
canvas->restoreToCount(saveCount);
canvas->flush();
}
@@ -893,7 +893,7 @@ void PlaybackCreationRenderer::setup() {
factory.get(),
this->recordFlags());
this->scaleToScaleFactor(canvas);
- canvas->drawPicture(*fPicture);
+ canvas->drawPicture(fPicture);
}
bool PlaybackCreationRenderer::render(SkBitmap** out) {
« include/core/SkCanvas.h ('K') | « tools/PdfRenderer.cpp ('k') | tools/lua/lua_pictures.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698