src/utils/debugger/SkDebugCanvas.h - Issue 313613004: Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/debugger/SkDebugCanvas.h

Issue 313613004: Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer) (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add staging entry point for Chromium and Android Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/utils/debugger/SkDebugCanvas.h

diff --git a/src/utils/debugger/SkDebugCanvas.h b/src/utils/debugger/SkDebugCanvas.h

index e94f30f33559f881f938a398cac21543882f0fc0..f15b397251e7b4e4ea989871506f356abc43810a 100644

--- a/src/utils/debugger/SkDebugCanvas.h

+++ b/src/utils/debugger/SkDebugCanvas.h

@@ -189,8 +189,6 @@ public:

virtual void drawPath(const SkPath& path, const SkPaint&) SK_OVERRIDE;

- virtual void drawPicture(SkPicture& picture) SK_OVERRIDE;

virtual void drawPoints(PointMode, size_t count, const SkPoint pts[],

const SkPaint&) SK_OVERRIDE;

@@ -257,6 +255,8 @@ protected:

virtual void onClipPath(const SkPath&, SkRegion::Op, ClipEdgeStyle) SK_OVERRIDE;

virtual void onClipRegion(const SkRegion& region, SkRegion::Op) SK_OVERRIDE;

+ virtual void onDrawPicture(const SkPicture* picture) SK_OVERRIDE;

void markActiveCommands(int index);

private:

« include/core/SkCanvas.h ('K') | « src/utils/SkProxyCanvas.cpp ('k') | src/utils/debugger/SkDebugCanvas.cpp » ('j') | no next file with comments »