src/effects/SkPictureImageFilter.cpp - Issue 313613004: Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkPictureImageFilter.cpp

Issue 313613004: Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer) (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add staging entry point for Chromium and Android Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/SkPictureImageFilter.cpp

diff --git a/src/effects/SkPictureImageFilter.cpp b/src/effects/SkPictureImageFilter.cpp

index af9466f977620b243b9a0c7b3f17a7b62e75aa3e..2d2df9231eabd84f71ce4b8338a900d02b42920c 100644

--- a/src/effects/SkPictureImageFilter.cpp

+++ b/src/effects/SkPictureImageFilter.cpp

@@ -85,7 +85,7 @@ bool SkPictureImageFilter::onFilterImage(Proxy* proxy, const SkBitmap&, const Co

canvas.translate(-SkIntToScalar(bounds.fLeft), -SkIntToScalar(bounds.fTop));

canvas.concat(ctx.ctm());

- canvas.drawPicture(*fPicture);

+ canvas.drawPicture(fPicture);

*result = device.get()->accessBitmap(false);

offset->fX = bounds.fLeft;

« include/core/SkCanvas.h ('K') | « src/core/SkPictureShader.cpp ('k') | src/gpu/GrLayerCache.h » ('j') | no next file with comments »