samplecode/SamplePictFile.cpp - Issue 313613004: Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samplecode/SamplePictFile.cpp

Issue 313613004: Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer) (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add staging entry point for Chromium and Android Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: samplecode/SamplePictFile.cpp

diff --git a/samplecode/SamplePictFile.cpp b/samplecode/SamplePictFile.cpp

index 7b9584d305cd88a499cf27d1b59783353dc66210..9e9764c4330ff843c36371620669b1bcfdc5f52d 100644

--- a/samplecode/SamplePictFile.cpp

+++ b/samplecode/SamplePictFile.cpp

@@ -100,7 +100,7 @@ protected:

*picture = LoadPicture(fFilename.c_str(), fBBox);

}

if (*picture) {

- canvas->drawPicture(**picture);

+ canvas->drawPicture(*picture);

}

@@ -140,7 +140,7 @@ private:

if (false) {

SkSurface* surf = SkSurface::NewRasterPMColor(pic->width(), pic->height());

- surf->getCanvas()->drawPicture(*pic);

+ surf->getCanvas()->drawPicture(pic);

surf->unref();

}

if (false) { // re-record

« include/core/SkCanvas.h ('K') | « samplecode/SampleApp.cpp ('k') | samplecode/SamplePicture.cpp » ('j') | no next file with comments »