include/utils/SkDumpCanvas.h - Issue 313613004: Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/utils/SkDumpCanvas.h

Issue 313613004: Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer) (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add staging entry point for Chromium and Android Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/utils/SkDumpCanvas.h

diff --git a/include/utils/SkDumpCanvas.h b/include/utils/SkDumpCanvas.h

index 6fc679bfeb4e01327004238ebf1090c39da07f9d..0aa55463b4de2d36e6455b7f6b27bac948603cdc 100644

--- a/include/utils/SkDumpCanvas.h

+++ b/include/utils/SkDumpCanvas.h

@@ -90,7 +90,6 @@ public:

const SkPaint* paint) SK_OVERRIDE;

virtual void drawSprite(const SkBitmap& bitmap, int left, int top,

const SkPaint* paint) SK_OVERRIDE;

- virtual void drawPicture(SkPicture&) SK_OVERRIDE;

virtual void drawVertices(VertexMode vmode, int vertexCount,

const SkPoint vertices[], const SkPoint texs[],

const SkColor colors[], SkXfermode* xmode,

@@ -126,6 +125,8 @@ protected:

virtual void onClipPath(const SkPath&, SkRegion::Op, ClipEdgeStyle) SK_OVERRIDE;

virtual void onClipRegion(const SkRegion&, SkRegion::Op) SK_OVERRIDE;

+ virtual void onDrawPicture(const SkPicture*) SK_OVERRIDE;

static const char* EdgeStyleToAAString(ClipEdgeStyle edgeStyle);

private:

« include/core/SkCanvas.h ('K') | « include/utils/SkDeferredCanvas.h ('k') | include/utils/SkLuaCanvas.h » ('j') | no next file with comments »