Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 313553002: Add the navigator.serviceWorker.waiting property. (Closed)

Created:
6 years, 6 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 6 months ago
Reviewers:
tkent, falken, jsbell
CC:
blink-reviews, jsbell+serviceworker_chromium.org, jamesr, tzik, serviceworker-reviews, nhiroki, abarth-chromium, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

Add the navigator.serviceWorker.waiting property. The value of this property will be null because it is not being set by the embedder yet. BUG=379012 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175520

Patch Set 1 #

Patch Set 2 : Bring patch to head. #

Patch Set 3 : Bring patch to head. #

Patch Set 4 : Rebaselines. #

Patch Set 5 : Bring patch to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -10 lines) Patch
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/serviceworker/serviceworkercontainer-interface.html View 1 chunk +24 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.h View 1 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 2 3 4 1 chunk +20 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.idl View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M public/platform/WebServiceWorkerProviderClient.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 29 (0 generated)
dominicc (has gone to gerrit)
PTAL The deleteIfNoExistingOwner thing is Blink-side follow-on from https://codereview.chromium.org/309503014/
6 years, 6 months ago (2014-06-03 05:54:54 UTC) #1
dominicc (has gone to gerrit)
+tkent for public/platform
6 years, 6 months ago (2014-06-03 05:55:20 UTC) #2
tkent
lgtm
6 years, 6 months ago (2014-06-03 06:02:40 UTC) #3
dominicc (has gone to gerrit)
-jsbell, no response assume he's busy; +falken. PTAL for modules/serviceworkers OWNERS. kthxbye.
6 years, 6 months ago (2014-06-04 01:58:32 UTC) #4
falken
lgtm
6 years, 6 months ago (2014-06-04 02:12:25 UTC) #5
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 6 months ago (2014-06-04 02:17:08 UTC) #6
dominicc (has gone to gerrit)
The CQ bit was unchecked by dominicc@chromium.org
6 years, 6 months ago (2014-06-04 02:17:25 UTC) #7
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 6 months ago (2014-06-04 02:20:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/313553002/40001
6 years, 6 months ago (2014-06-04 02:20:31 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-04 03:12:38 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 03:15:11 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/10675)
6 years, 6 months ago (2014-06-04 03:15:12 UTC) #12
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 6 months ago (2014-06-04 03:25:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/313553002/40001
6 years, 6 months ago (2014-06-04 03:25:43 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-04 04:37:29 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 04:37:52 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/13721)
6 years, 6 months ago (2014-06-04 04:37:53 UTC) #17
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 6 months ago (2014-06-04 07:06:22 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/313553002/40001
6 years, 6 months ago (2014-06-04 07:06:51 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-04 08:37:17 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 08:59:02 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/10941)
6 years, 6 months ago (2014-06-04 08:59:03 UTC) #22
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 6 months ago (2014-06-04 17:50:31 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/313553002/60001
6 years, 6 months ago (2014-06-04 17:51:21 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 17:51:31 UTC) #25
commit-bot: I haz the power
Failed to apply patch for Source/modules/serviceworkers/ServiceWorkerContainer.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-04 17:51:32 UTC) #26
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 6 months ago (2014-06-05 01:19:04 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/313553002/80001
6 years, 6 months ago (2014-06-05 01:19:12 UTC) #28
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 02:23:21 UTC) #29
Message was sent while issue was closed.
Change committed as 175520

Powered by Google App Engine
This is Rietveld 408576698