Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 313523002: Improved message when CL description is missing (Closed)

Created:
6 years, 6 months ago by pgervais
Modified:
6 years, 6 months ago
Reviewers:
iannucci, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Improved message when CL description is missing 'Add a description' is not enough to know what the test is about. Added some more info. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=274393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M presubmit_canned_checks.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pgervais
Very simple change.
6 years, 6 months ago (2014-06-03 00:47:27 UTC) #1
iannucci
lgtm
6 years, 6 months ago (2014-06-03 00:50:44 UTC) #2
pgervais
The CQ bit was checked by pgervais@chromium.org
6 years, 6 months ago (2014-06-03 00:51:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pgervais@chromium.org/313523002/1
6 years, 6 months ago (2014-06-03 00:52:16 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 00:53:49 UTC) #5
Message was sent while issue was closed.
Change committed as 274393

Powered by Google App Engine
This is Rietveld 408576698