Issue 313513002: Remove viewport tag from test page for pixel tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 313513002: Remove viewport tag from test page for pixel tests. (Closed)

Created:
6 years, 6 months ago by alokp

Modified:
6 years, 6 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove viewport tag from test page for pixel tests. The viewport tag makes the test fail for unknown reasons on just one bot: win7-nvidia-release. BUG=368495 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274488

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	content/test/data/gpu/pixel_css3d.html	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	content/test/gpu/page_sets/pixel_tests.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

lgtm https://codereview.chromium.org/313513002/diff/1/content/test/gpu/page_sets/pixel_tests.py File content/test/gpu/page_sets/pixel_tests.py (right): https://codereview.chromium.org/313513002/diff/1/content/test/gpu/page_sets/pixel_tests.py#newcode45 content/test/gpu/page_sets/pixel_tests.py:45: revision=8, Please remember to submit a follow-on CL ...

6 years, 6 months ago (2014-06-02 23:39:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/313513002/1

6 years, 6 months ago (2014-06-03 03:57:34 UTC) #4

Message was sent while issue was closed.

Change committed as 274488

Expand Messages | Collapse Messages