Issue 3135034: Cleanup: Put signal handlers in alphabetical order. Group a couple other thi...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3135034: Cleanup: Put signal handlers in alphabetical order. Group a couple other thi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by Peter Kasting

Modified:
4 years ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Cleanup: Put signal handlers in alphabetical order. Group a couple other things in a way that seems better to me. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56767

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -21 lines)			Patch
	M	chrome/browser/gtk/reload_button_gtk.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/gtk/reload_button_gtk.cc	View		4 chunks	+19 lines, -20 lines	0 comments	Download

Trybot results:

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

4 years, 9 months ago (2010-08-19 22:06:07 UTC) #2

LGTM

On Thu, Aug 19, 2010 at 3:00 PM,  <pkasting@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Description:
> Cleanup: Put signal handlers in alphabetical order.  Group a couple other
> things
> in a way that seems better to me.
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/3135034/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/gtk/reload_button_gtk.h
>  M     chrome/browser/gtk/reload_button_gtk.cc
>
>
>

Expand Messages | Collapse Messages