Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 313483002: Gets aura_demo working with the view_manager (Closed)

Created:
6 years, 6 months ago by sky
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Gets aura_demo working with the view_manager I made it talk directly to the view_manager. We'll likely want a variant that talks to the client_lib too. BUG=365012 TEST=covered by tests R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274449

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : merge 2 master and fix windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+548 lines, -21 lines) Patch
M mojo/examples/aura_demo/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/examples/aura_demo/aura_demo.cc View 5 chunks +83 lines, -17 lines 0 comments Download
A mojo/examples/aura_demo/context_factory_view_manager.h View 1 chunk +48 lines, -0 lines 0 comments Download
A mojo/examples/aura_demo/context_factory_view_manager.cc View 1 1 chunk +194 lines, -0 lines 0 comments Download
A mojo/examples/aura_demo/view_manager_init.cc View 1 chunk +46 lines, -0 lines 0 comments Download
A mojo/examples/aura_demo/window_tree_host_view_manager.h View 1 chunk +51 lines, -0 lines 0 comments Download
A mojo/examples/aura_demo/window_tree_host_view_manager.cc View 1 chunk +96 lines, -0 lines 0 comments Download
M mojo/mojo.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 2 1 chunk +25 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
6 years, 6 months ago (2014-06-02 20:44:00 UTC) #1
Ben Goodger (Google)
lgtm. looks like there are some bits of potential shared code here. context factory. window ...
6 years, 6 months ago (2014-06-02 21:38:49 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-02 22:05:15 UTC) #3
sky
Totally agree on the reusable part. We can shuffle things around as we get more ...
6 years, 6 months ago (2014-06-02 22:05:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/313483002/40001
6 years, 6 months ago (2014-06-02 22:06:54 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 09:16:28 UTC) #6
Message was sent while issue was closed.
Change committed as 274449

Powered by Google App Engine
This is Rietveld 408576698