Remove gesture configuration from about://gesture

chrome/browser/ui/gesture_prefs_observer_factory_aura.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gesture_prefs_observer_factory_aura.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/compiler_specific.h"
 #include "base/prefs/pref_change_registrar.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/profiles/incognito_helpers.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/pref_names.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/overscroll_configuration.h"
 #include "content/public/common/renderer_preferences.h"
 #include "ui/events/gestures/gesture_configuration.h"
 
 using ui::GestureConfiguration;
 
 namespace {
 
+// TODO(tdresser): Remove these deprecated prefs in M38. See crbug.com/379912.
+
+const char kFlingVelocityCap[] = "gesture.fling_velocity_cap";
+const char kLongPressTimeInSeconds[] =
+    "gesture.long_press_time_in_seconds";
+const char kMaxDistanceBetweenTapsForDoubleTap[] =
+    "gesture.max_distance_between_taps_for_double_tap";
+const char kMaxDistanceForTwoFingerTapInPixels[] =
+    "gesture.max_distance_for_two_finger_tap_in_pixels";
+const char kMaxSecondsBetweenDoubleClick[] =
+    "gesture.max_seconds_between_double_click";
+const char kMaxSwipeDeviationRatio[] =
+    "gesture.max_swipe_deviation_ratio";
+const char kMaxTouchDownDurationInSecondsForClick[] =
+    "gesture.max_touch_down_duration_in_seconds_for_click";
+const char kMaxTouchMoveInPixelsForClick[] =
+    "gesture.max_touch_move_in_pixels_for_click";
+const char kMinDistanceForPinchScrollInPixels[] =
+    "gesture.min_distance_for_pinch_scroll_in_pixels";
+const char kMinFlickSpeedSquared[] =
+    "gesture.min_flick_speed_squared";
+const char kMinPinchUpdateDistanceInPixels[] =
+    "gesture.min_pinch_update_distance_in_pixels";
+const char kMinRailBreakVelocity[] =
+    "gesture.min_rail_break_velocity";
+const char kMinScrollDeltaSquared[] =
+    "gesture.min_scroll_delta_squared";
+const char kMinSwipeSpeed[] =
+    "gesture.min_swipe_speed";
+const char kMinTouchDownDurationInSecondsForClick[] =
+    "gesture.min_touch_down_duration_in_seconds_for_click";
+const char kPointsBufferedForVelocity[] =
+    "gesture.points_buffered_for_velocity";
+const char kRailBreakProportion[] =
+    "gesture.rail_break_proportion";
+const char kRailStartProportion[] =
+    "gesture.rail_start_proportion";
+const char kScrollPredictionSeconds[] =
+    "gesture.scroll_prediction_seconds";
+const char kShowPressDelayInMS[] =
+    "gesture.show_press_delay_in_ms";
+
 struct OverscrollPref {
   const char* pref_name;
   content::OverscrollConfig config;
 };
 
 const std::vector<OverscrollPref>& GetOverscrollPrefs() {
   CR_DEFINE_STATIC_LOCAL(std::vector<OverscrollPref>, overscroll_prefs, ());
   if (overscroll_prefs.empty()) {
     using namespace content;
     const OverscrollPref kOverscrollPrefs[] = {
@@ skipping 51 matching lines @@
 // Note that this collection of settings should correspond to the settings used
 // in ui/events/gestures/gesture_configuration.h
 const char* kPrefsToObserve[] = {
   prefs::kFlingAccelerationCurveCoefficient0,
   prefs::kFlingAccelerationCurveCoefficient1,
   prefs::kFlingAccelerationCurveCoefficient2,
   prefs::kFlingAccelerationCurveCoefficient3,
   prefs::kFlingMaxCancelToDownTimeInMs,
   prefs::kFlingMaxTapGapTimeInMs,
   prefs::kTabScrubActivationDelayInMS,
-  prefs::kFlingVelocityCap,
-  prefs::kLongPressTimeInSeconds,
-  prefs::kMaxDistanceForTwoFingerTapInPixels,
-  prefs::kMaxSecondsBetweenDoubleClick,
   prefs::kMaxSeparationForGestureTouchesInPixels,
-  prefs::kMaxSwipeDeviationRatio,
-  prefs::kMaxTouchDownDurationInSecondsForClick,
-  prefs::kMaxTouchMoveInPixelsForClick,
-  prefs::kMinDistanceForPinchScrollInPixels,
-  prefs::kMinFlickSpeedSquared,
-  prefs::kMinPinchUpdateDistanceInPixels,
-  prefs::kMinRailBreakVelocity,
-  prefs::kMinScrollDeltaSquared,
-  prefs::kMinSwipeSpeed,
-  prefs::kMinTouchDownDurationInSecondsForClick,
-  prefs::kPointsBufferedForVelocity,
-  prefs::kRailBreakProportion,
-  prefs::kRailStartProportion,
   prefs::kSemiLongPressTimeInSeconds,
-  prefs::kShowPressDelayInMS,
 };
 
 const char* kFlingTouchpadPrefs[] = {
   prefs::kFlingCurveTouchpadAlpha,
   prefs::kFlingCurveTouchpadBeta,
   prefs::kFlingCurveTouchpadGamma
 };
 
 const char* kFlingTouchscreenPrefs[] = {
   prefs::kFlingCurveTouchscreenAlpha,
   prefs::kFlingCurveTouchscreenBeta,
   prefs::kFlingCurveTouchscreenGamma,
 };
 
 GesturePrefsObserver::GesturePrefsObserver(PrefService* prefs)
     : prefs_(prefs) {
+  // Clear for migration.
+  prefs->ClearPref(kFlingVelocityCap);
+  prefs->ClearPref(kLongPressTimeInSeconds);
+  prefs->ClearPref(kMaxDistanceBetweenTapsForDoubleTap);
+  prefs->ClearPref(kMaxDistanceForTwoFingerTapInPixels);
+  prefs->ClearPref(kMaxSecondsBetweenDoubleClick);
+  prefs->ClearPref(kMaxSwipeDeviationRatio);
+  prefs->ClearPref(kMaxTouchDownDurationInSecondsForClick);
+  prefs->ClearPref(kMaxTouchMoveInPixelsForClick);
+  prefs->ClearPref(kMinDistanceForPinchScrollInPixels);
+  prefs->ClearPref(kMinFlickSpeedSquared);
+  prefs->ClearPref(kMinPinchUpdateDistanceInPixels);
+  prefs->ClearPref(kMinRailBreakVelocity);
+  prefs->ClearPref(kMinScrollDeltaSquared);
+  prefs->ClearPref(kMinSwipeSpeed);
+  prefs->ClearPref(kMinTouchDownDurationInSecondsForClick);
+  prefs->ClearPref(kPointsBufferedForVelocity);
+  prefs->ClearPref(kRailBreakProportion);
+  prefs->ClearPref(kRailStartProportion);
+  prefs->ClearPref(kScrollPredictionSeconds);
+  prefs->ClearPref(kShowPressDelayInMS);

[sadrul, 2014/06/03 10:25:47]

1. Maybe you need to FindPreference() first for each of these before doing
ClearPref (because ClearPref() has a NOTREACHED() for unregistered prefs, and a
reboot after clearing the prefs will probably trigger that?)

2. Why not a kFlagsToRemove array of prefs, instead of calling each by name?

[tdresser, 2014/06/03 12:13:04]

Registering the prefs to be removed stops the NOTREACHED() from being hit, but
using FindPreference is clearly better, thanks.

Done.

+
   registrar_.Init(prefs);
   registrar_.RemoveAll();
   base::Closure callback = base::Bind(&GesturePrefsObserver::Update,
                                       base::Unretained(this));
 
   base::Closure notify_callback = base::Bind(&GesturePrefsObserver::Notify,
                                              base::Unretained(this));
 
   for (size_t i = 0; i < arraysize(kPrefsToObserve); ++i)
     registrar_.Add(kPrefsToObserve[i], callback);
@@ skipping 24 matching lines @@
   GestureConfiguration::set_fling_acceleration_curve_coefficients(2,
       prefs_->GetDouble(prefs::kFlingAccelerationCurveCoefficient2));
   GestureConfiguration::set_fling_acceleration_curve_coefficients(3,
       prefs_->GetDouble(prefs::kFlingAccelerationCurveCoefficient3));
   GestureConfiguration::set_fling_max_cancel_to_down_time_in_ms(
       prefs_->GetInteger(prefs::kFlingMaxCancelToDownTimeInMs));
   GestureConfiguration::set_fling_max_tap_gap_time_in_ms(
       prefs_->GetInteger(prefs::kFlingMaxTapGapTimeInMs));
   GestureConfiguration::set_tab_scrub_activation_delay_in_ms(
       prefs_->GetInteger(prefs::kTabScrubActivationDelayInMS));
-  GestureConfiguration::set_fling_velocity_cap(
-      prefs_->GetDouble(prefs::kFlingVelocityCap));
-  GestureConfiguration::set_long_press_time_in_seconds(
-      prefs_->GetDouble(
-          prefs::kLongPressTimeInSeconds));
   GestureConfiguration::set_semi_long_press_time_in_seconds(
       prefs_->GetDouble(
           prefs::kSemiLongPressTimeInSeconds));
-  GestureConfiguration::set_max_distance_for_two_finger_tap_in_pixels(
-      prefs_->GetDouble(
-          prefs::kMaxDistanceForTwoFingerTapInPixels));
-  GestureConfiguration::set_max_seconds_between_double_click(
-      prefs_->GetDouble(
-          prefs::kMaxSecondsBetweenDoubleClick));
   GestureConfiguration::set_max_separation_for_gesture_touches_in_pixels(
       prefs_->GetDouble(
           prefs::kMaxSeparationForGestureTouchesInPixels));
-  GestureConfiguration::set_max_swipe_deviation_ratio(
-      prefs_->GetDouble(
-          prefs::kMaxSwipeDeviationRatio));
-  GestureConfiguration::set_max_touch_down_duration_in_seconds_for_click(
-      prefs_->GetDouble(
-          prefs::kMaxTouchDownDurationInSecondsForClick));
-  GestureConfiguration::set_max_touch_move_in_pixels_for_click(
-      prefs_->GetDouble(
-          prefs::kMaxTouchMoveInPixelsForClick));
-  GestureConfiguration::set_max_distance_between_taps_for_double_tap(
-      prefs_->GetDouble(
-          prefs::kMaxDistanceBetweenTapsForDoubleTap));
-  GestureConfiguration::set_min_distance_for_pinch_scroll_in_pixels(
-      prefs_->GetDouble(
-          prefs::kMinDistanceForPinchScrollInPixels));
-  GestureConfiguration::set_min_flick_speed_squared(
-      prefs_->GetDouble(
-          prefs::kMinFlickSpeedSquared));
-  GestureConfiguration::set_min_pinch_update_distance_in_pixels(
-      prefs_->GetDouble(
-          prefs::kMinPinchUpdateDistanceInPixels));
-  GestureConfiguration::set_min_rail_break_velocity(
-      prefs_->GetDouble(
-          prefs::kMinRailBreakVelocity));
-  GestureConfiguration::set_min_scroll_delta_squared(
-      prefs_->GetDouble(
-          prefs::kMinScrollDeltaSquared));
-  GestureConfiguration::set_min_swipe_speed(
-      prefs_->GetDouble(
-          prefs::kMinSwipeSpeed));
-  GestureConfiguration::set_min_touch_down_duration_in_seconds_for_click(
-      prefs_->GetDouble(
-          prefs::kMinTouchDownDurationInSecondsForClick));
-  GestureConfiguration::set_points_buffered_for_velocity(
-      prefs_->GetInteger(
-          prefs::kPointsBufferedForVelocity));
-  GestureConfiguration::set_rail_break_proportion(
-      prefs_->GetDouble(
-          prefs::kRailBreakProportion));
-  GestureConfiguration::set_rail_start_proportion(
-      prefs_->GetDouble(
-          prefs::kRailStartProportion));
-  GestureConfiguration::set_scroll_prediction_seconds(
-      prefs_->GetDouble(prefs::kScrollPredictionSeconds));
-  GestureConfiguration::set_show_press_delay_in_ms(
-      prefs_->GetInteger(prefs::kShowPressDelayInMS));
 
   UpdateOverscrollPrefs();
 }
 
 void GesturePrefsObserver::UpdateOverscrollPrefs() {
   const std::vector<OverscrollPref>& overscroll_prefs = GetOverscrollPrefs();
   for (size_t i = 0; i < overscroll_prefs.size(); ++i) {
     content::SetOverscrollConfig(overscroll_prefs[i].config,
         static_cast<float>(prefs_->GetDouble(overscroll_prefs[i].pref_name)));
   }
@@ skipping 81 matching lines @@
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterIntegerPref(
       prefs::kFlingMaxTapGapTimeInMs,
       GestureConfiguration::fling_max_tap_gap_time_in_ms(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterIntegerPref(
       prefs::kTabScrubActivationDelayInMS,
       GestureConfiguration::tab_scrub_activation_delay_in_ms(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDoublePref(
-      prefs::kFlingVelocityCap,
-      GestureConfiguration::fling_velocity_cap(),
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterDoublePref(
-      prefs::kLongPressTimeInSeconds,
-      GestureConfiguration::long_press_time_in_seconds(),
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterDoublePref(
       prefs::kSemiLongPressTimeInSeconds,
       GestureConfiguration::semi_long_press_time_in_seconds(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDoublePref(
-      prefs::kMaxDistanceForTwoFingerTapInPixels,
+      prefs::kMaxSeparationForGestureTouchesInPixels,
+      GestureConfiguration::max_separation_for_gesture_touches_in_pixels(),
+      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+  RegisterOverscrollPrefs(registry);
+  RegisterFlingCurveParameters(registry);
+
+  // Register for migration.
+  registry->RegisterDoublePref(

[sadrul, 2014/06/03 10:25:47]

Why register these anymore?

[tdresser, 2014/06/03 12:13:04]

Hmmm, I was using
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/gesture_pre...
as a model (originally by rjkroege).

There are two options, one is to only call ClearPref if FindPreference returns
something, the other option is to always register all the prefs. 

I definitely prefer the way you're proposing.
Done.

+      kFlingVelocityCap,
+      GestureConfiguration::fling_velocity_cap(),
+      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+  registry->RegisterDoublePref(
+      kLongPressTimeInSeconds,
+      GestureConfiguration::long_press_time_in_seconds(),
+      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+  registry->RegisterDoublePref(
+      kMaxDistanceForTwoFingerTapInPixels,
       GestureConfiguration::max_distance_for_two_finger_tap_in_pixels(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDoublePref(
-      prefs::kMaxSecondsBetweenDoubleClick,
+      kMaxSecondsBetweenDoubleClick,
       GestureConfiguration::max_seconds_between_double_click(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDoublePref(
-      prefs::kMaxSeparationForGestureTouchesInPixels,
-      GestureConfiguration::max_separation_for_gesture_touches_in_pixels(),
-      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  registry->RegisterDoublePref(
-      prefs::kMaxSwipeDeviationRatio,
+      kMaxSwipeDeviationRatio,
       GestureConfiguration::max_swipe_deviation_ratio(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDoublePref(
-      prefs::kMaxTouchDownDurationInSecondsForClick,
+      kMaxTouchDownDurationInSecondsForClick,
       GestureConfiguration::max_touch_down_duration_in_seconds_for_click(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDoublePref(
-      prefs::kMaxTouchMoveInPixelsForClick,
+      kMaxTouchMoveInPixelsForClick,
       GestureConfiguration::max_touch_move_in_pixels_for_click(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDoublePref(
-      prefs::kMaxDistanceBetweenTapsForDoubleTap,
+      kMaxDistanceBetweenTapsForDoubleTap,
       GestureConfiguration::max_distance_between_taps_for_double_tap(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDoublePref(
-      prefs::kMinDistanceForPinchScrollInPixels,
+      kMinDistanceForPinchScrollInPixels,
       GestureConfiguration::min_distance_for_pinch_scroll_in_pixels(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDoublePref(
-      prefs::kMinFlickSpeedSquared,
+      kMinFlickSpeedSquared,
       GestureConfiguration::min_flick_speed_squared(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDoublePref(
-      prefs::kMinPinchUpdateDistanceInPixels,
+      kMinPinchUpdateDistanceInPixels,
       GestureConfiguration::min_pinch_update_distance_in_pixels(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDoublePref(
-      prefs::kMinRailBreakVelocity,
+      kMinRailBreakVelocity,
       GestureConfiguration::min_rail_break_velocity(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDoublePref(
-      prefs::kMinScrollDeltaSquared,
+      kMinScrollDeltaSquared,
       GestureConfiguration::min_scroll_delta_squared(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDoublePref(
-      prefs::kMinSwipeSpeed,
+      kMinSwipeSpeed,
       GestureConfiguration::min_swipe_speed(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDoublePref(
-      prefs::kMinTouchDownDurationInSecondsForClick,
+      kMinTouchDownDurationInSecondsForClick,
       GestureConfiguration::min_touch_down_duration_in_seconds_for_click(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterIntegerPref(
-      prefs::kPointsBufferedForVelocity,
+      kPointsBufferedForVelocity,
       GestureConfiguration::points_buffered_for_velocity(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDoublePref(
-      prefs::kRailBreakProportion,
+      kRailBreakProportion,
       GestureConfiguration::rail_break_proportion(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDoublePref(
-      prefs::kRailStartProportion,
+      kRailStartProportion,
       GestureConfiguration::rail_start_proportion(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterDoublePref(
-      prefs::kScrollPredictionSeconds,
+      kScrollPredictionSeconds,
       GestureConfiguration::scroll_prediction_seconds(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterIntegerPref(
-      prefs::kShowPressDelayInMS,
+      kShowPressDelayInMS,
       GestureConfiguration::show_press_delay_in_ms(),
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-  RegisterOverscrollPrefs(registry);
-  RegisterFlingCurveParameters(registry);
 }
 
 bool
 GesturePrefsObserverFactoryAura::ServiceIsCreatedWithBrowserContext() const {
   // Create the observer as soon as the profile is created.
   return true;
 }
 
 content::BrowserContext*
 GesturePrefsObserverFactoryAura::GetBrowserContextToUse(
     content::BrowserContext* context) const {
   // Use same gesture preferences on incognito windows.
   return chrome::GetBrowserContextRedirectedInIncognito(context);
 }
 
 bool GesturePrefsObserverFactoryAura::ServiceIsNULLWhileTesting() const {
   // Some tests replace the PrefService of the TestingProfile after the
   // GesturePrefsObserver has been created, which makes Shutdown()
   // remove the registrar from a non-existent PrefService.
   return true;
 }