Fix deferred library code disabling for inlined functions.

runtime/vm/parser.cc

Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc	(revision 37101)
+++ runtime/vm/parser.cc	(working copy)
@@ -136,16 +136,12 @@
 void ParsedFunction::AddDeferredPrefix(const LibraryPrefix& prefix) {
   ASSERT(prefix.is_deferred_load());
   ASSERT(!prefix.is_loaded());
-  if (deferred_prefixes_ == NULL) {
-    deferred_prefixes_ =
-        &GrowableObjectArray::ZoneHandle(GrowableObjectArray::New());

[hausner, 2014/06/06 22:07:44]

We pay this price only in the rare case where we find deferred prefixes.

[srdjan, 2014/06/06 22:14:34]

The new solution simplifies the code and makes it more robust, IMO, as we do not
need to check for NULL here and when adding inlined deferred library prefixes.
The array is allocated once per parsing, the overhead seems small.

-  }
-  for (intptr_t i = 0; i < deferred_prefixes_->Length(); i++) {
-    if (deferred_prefixes_->At(i) == prefix.raw()) {
+  for (intptr_t i = 0; i < deferred_prefixes_->length(); i++) {
+    if ((*deferred_prefixes_)[i]->raw() == prefix.raw()) {
       return;
     }
   }
-  deferred_prefixes_->Add(prefix);
+  deferred_prefixes_->Add(&LibraryPrefix::ZoneHandle(I, prefix.raw()));
 }