Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 313393005: Encoding API: Handle null input string (Closed)

Created:
6 years, 6 months ago by jsbell
Modified:
6 years, 6 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Encoding API: Handle null input string BUG=382589 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175818

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M LayoutTests/fast/encoding/api/basics.html View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/encoding/TextEncoder.cpp View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jsbell
Missing case discovered while tinkering with bindings. ojan@ - can you take a look?
6 years, 6 months ago (2014-06-09 18:37:26 UTC) #1
jsbell
or kbr@ as an actual module OWNERS member :)
6 years, 6 months ago (2014-06-09 18:40:33 UTC) #2
Ken Russell (switch to Gerrit)
lgtm
6 years, 6 months ago (2014-06-09 18:41:41 UTC) #3
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 6 months ago (2014-06-09 18:42:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/313393005/1
6 years, 6 months ago (2014-06-09 18:42:41 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 19:45:41 UTC) #6
Message was sent while issue was closed.
Change committed as 175818

Powered by Google App Engine
This is Rietveld 408576698