runtime/vm/snapshot.h - Issue 313393003: Changes to improve the performance of reading a snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/snapshot.h

Issue 313393003: Changes to improve the performance of reading a snapshot. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/snapshot.h

===================================================================

--- runtime/vm/snapshot.h (revision 37116)

+++ runtime/vm/snapshot.h (working copy)

@@ -176,7 +176,11 @@

// Reads an intptr_t type value.

intptr_t ReadIntptrValue() {

+ #if defined(ARCH_IS_32_BIT)

Ivan Posva 2014/06/09 20:48:20 As discussed I don't think this is safe.

zra 2014/06/09 22:02:43 Removed change here.

+ int32_t value = Read<int32_t>();

+ #elif defined(ARCH_IS_64_BIT)

int64_t value = Read<int64_t>();

+ #endif

ASSERT((value <= kIntptrMax) && (value >= kIntptrMin));

return static_cast<intptr_t>(value);

}

« no previous file with comments | « runtime/vm/pages.cc ('k') | no next file » | no next file with comments »