Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: chrome/browser/ui/settings_window_manager.h

Issue 313363004: Separate Settings and Help from History and Extensions when settings-in- (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: feedback Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_SETTINGS_WINDOW_MANAGER_H_ 5 #ifndef CHROME_BROWSER_UI_SETTINGS_WINDOW_MANAGER_H_
6 #define CHROME_BROWSER_UI_SETTINGS_WINDOW_MANAGER_H_ 6 #define CHROME_BROWSER_UI_SETTINGS_WINDOW_MANAGER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
(...skipping 12 matching lines...) Expand all
23 // Class for managing settings windows when --enable-settings-window is enabled. 23 // Class for managing settings windows when --enable-settings-window is enabled.
24 // TODO(stevenjb): Remove flag comment if enabled by default. 24 // TODO(stevenjb): Remove flag comment if enabled by default.
25 25
26 class SettingsWindowManager { 26 class SettingsWindowManager {
27 public: 27 public:
28 static SettingsWindowManager* GetInstance(); 28 static SettingsWindowManager* GetInstance();
29 29
30 void AddObserver(SettingsWindowManagerObserver* observer); 30 void AddObserver(SettingsWindowManagerObserver* observer);
31 void RemoveObserver(SettingsWindowManagerObserver* observer); 31 void RemoveObserver(SettingsWindowManagerObserver* observer);
32 32
33 // Shows a chrome:// page (e.g. Settings, History) in an an existing system 33 // Shows a chrome:// page (e.g. Settings, Help) in an an existing system
Dan Beam 2014/06/06 21:21:23 ^ shouldn't this be About, now? ;)
michaelpg 2014/06/07 02:12:15 Done, thanks.
34 // Browser window for |profile| or creates a new one. 34 // Browser window for |profile| or creates a new one.
35 void ShowChromePageForProfile(Profile* profile, const GURL& gurl); 35 void ShowChromePageForProfile(Profile* profile, const GURL& gurl);
36 36
37 // If a Browser settings window for |profile| has already been created, 37 // If a Browser settings window for |profile| has already been created,
38 // returns it, otherwise returns NULL. 38 // returns it, otherwise returns NULL.
39 Browser* FindBrowserForProfile(Profile* profile); 39 Browser* FindBrowserForProfile(Profile* profile);
40 40
41 private: 41 private:
42 friend struct DefaultSingletonTraits<SettingsWindowManager>; 42 friend struct DefaultSingletonTraits<SettingsWindowManager>;
43 typedef std::map<Profile*, SessionID::id_type> ProfileSessionMap; 43 typedef std::map<Profile*, SessionID::id_type> ProfileSessionMap;
44 44
45 SettingsWindowManager(); 45 SettingsWindowManager();
46 ~SettingsWindowManager(); 46 ~SettingsWindowManager();
47 47
48 ObserverList<SettingsWindowManagerObserver> observers_; 48 ObserverList<SettingsWindowManagerObserver> observers_;
49 ProfileSessionMap settings_session_map_; 49 ProfileSessionMap settings_session_map_;
50 50
51 DISALLOW_COPY_AND_ASSIGN(SettingsWindowManager); 51 DISALLOW_COPY_AND_ASSIGN(SettingsWindowManager);
52 }; 52 };
53 53
54 } // namespace chrome 54 } // namespace chrome
55 55
56 #endif // CHROME_BROWSER_UI_SETTINGS_WINDOW_MANAGER_H_ 56 #endif // CHROME_BROWSER_UI_SETTINGS_WINDOW_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698