Issue 313333002: Extract implementation based on timeline events into TimelineModelImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 313333002: Extract implementation based on timeline events into TimelineModelImpl (Closed)

Created:
6 years, 6 months ago by yurys

Modified:
6 years, 6 months ago

Reviewers:
caseq, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Extract implementation based on timeline events into TimelineModelImpl We will have two descendants of TimelineModel - one based on trace events and another one based on the timeline agent events. This change extracts the latter one. I left WebInspector.TimelineModel.RecordType to keep the patch short. Will move it to WebInspector.TimelineModelImpl.RecordType later. BUG=361045 R=caseq@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175577

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -1418 lines)			Patch
M	LayoutTests/inspector/timeline/timeline-load.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/devtools.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineModel.js	View		11 chunks	+11 lines, -704 lines	0 comments	Download
A +	Source/devtools/front_end/timeline/TimelineModelImpl.js	View		13 chunks	+17 lines, -712 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelinePanel.js	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/devtools/scripts/frontend_modules.json	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

6 years, 6 months ago (2014-06-05 15:17:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r175577 (presubmit successful).

Expand Messages | Collapse Messages