Make TestingProfile use ScopedTempDir.

Make TestingProfile use ScopedTempDir.

Add some logic that tries to recover from common errors
that happen on the bots. We need to CHECK in really bad cases
because otherwise we'd end up writing to places where we should never write,
like the filesystem root.

TEST=unit_tests and others
BUG=51833
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56909

[chron_chromium.org, 2010-08-19 22:05:32]

Does really nothing use the *count* param? When I tried this there were a few
files.

[sky, 2010-08-19 22:24:24]

I thought the other constructor was used too in a couple of places. Maybe
they've been nuked?

http://codereview.chromium.org/3133031/diff/1/3
File chrome/test/testing_profile.cc (right):

http://codereview.chromium.org/3133031/diff/1/3#newcode185
chrome/test/testing_profile.cc:185: FilePath
fallback_dir(system_tmp_dir.AppendASCII("TestingProfilePath"));
Do you need to make sure the directory is empty?

[Paweł Hajdan Jr., 2010-08-20 17:07:23]

Please take another look.

http://codereview.chromium.org/3133031/diff/1/3
File chrome/test/testing_profile.cc (right):

http://codereview.chromium.org/3133031/diff/1/3#newcode185
chrome/test/testing_profile.cc:185: FilePath
fallback_dir(system_tmp_dir.AppendASCII("TestingProfilePath"));
On 2010/08/19 22:24:24, sky wrote:
> Do you need to make sure the directory is empty?

Oh, good catch. Done.

[chron_chromium.org, 2010-08-20 19:54:23]

LGTM

[sky, 2010-08-20 20:05:29]

LGTM