Change shadow style's scope from Shadow Host to Shadow Root

Change shadow style's scope from Shadow Host to Shadow Root

No visible change, test expectation change is expected.

Scope of styles in shadow tree used to be its shadow host
for ease of checking the style against :host etc.

This caused code complexity for checking against boundary
breaking CSS selector rules (e.g. ::content, /deep/).
Changing the scope to its shadow root will simplify some
condition checks.

This is a step towards fixing issue 355674.

BUG=355674
TEST=pass all layout tests

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176304

[kochi, 2014-06-06 06:21:01]

Hi Takashi,

Although this could be improved (the code can be simplified)
more, this is the current cut of changing the scoping node
of CSS selector context of shadow tree from its host to
its root.

Could you take a glance?

[tasak, 2014-06-06 06:35:12]

On 2014/06/06 06:21:01, Takayoshi Kochi wrote:
> Hi Takashi,
> 
> Although this could be improved (the code can be simplified)
> more, this is the current cut of changing the scoping node
> of CSS selector context of shadow tree from its host to
> its root.
> 
> Could you take a glance?

lgtm.

The code is much simpler because of removing style scoped.

[kochi, 2014-06-12 07:17:14]

Hi Takashi,

No change since the last change, but as <style scoped>
removal landed and I am considering landing this.

Could you take another look?

Thanks,

[kochi, 2014-06-16 09:25:12]

On 2014/06/12 07:17:14, Takayoshi Kochi wrote:
> Hi Takashi,
> 
> No change since the last change, but as <style scoped>
> removal landed and I am considering landing this.
> 
> Could you take another look?
> 
> Thanks,

Assuming Takashi's LGTM is still valid - Elliott, could you take a look for
OWNERS LGTM?

[dglazkov, 2014-06-16 15:25:08]

lgtm

[kochi, 2014-06-17 02:44:07]

The CQ bit was checked by kochi@chromium.org

[commit-bot: I haz the power, 2014-06-17 02:44:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kochi@chromium.org/313303002/20001

[commit-bot: I haz the power, 2014-06-17 02:44:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 02:44:54]

Failed to apply patch for Source/core/css/TreeBoundaryCrossingRules.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/css/TreeBoundaryCrossingRules.cpp
  Hunk #1 FAILED at 83.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/css/TreeBoundaryCrossingRules.cpp.rej

Patch:       Source/core/css/TreeBoundaryCrossingRules.cpp
Index: Source/core/css/TreeBoundaryCrossingRules.cpp
diff --git a/Source/core/css/TreeBoundaryCrossingRules.cpp
b/Source/core/css/TreeBoundaryCrossingRules.cpp
index
e45aa3f8d1546a1beb9e5b3603d14e9dbfd2c914..5fbc3a739fe8400813d67c4aff3af97cc9ca72f5
100644
--- a/Source/core/css/TreeBoundaryCrossingRules.cpp
+++ b/Source/core/css/TreeBoundaryCrossingRules.cpp
@@ -83,18 +83,19 @@ void
TreeBoundaryCrossingRules::collectTreeBoundaryCrossingRules(Element* elemen
         bool isInnerTreeScope =
element->treeScope().isInclusiveAncestorOf(scopingNode->treeScope());
 
         // If a given scoping node is a shadow root,
-        // we should use ScopeIsShadowHost.
+        // we should use ScopeIsShadowRoot.
+        const ContainerNode* scopingHost = scopingNode;
         if (scopingNode && scopingNode->isShadowRoot()) {
-            boundaryBehavior |= SelectorChecker::ScopeIsShadowHost;
-            scopingNode = toShadowRoot(scopingNode)->host();
+            boundaryBehavior |= SelectorChecker::ScopeIsShadowRoot;
+            scopingHost = toShadowRoot(scopingNode)->host();
         }
 
         // FIXME: This is a terrible hack to avoid doing most of the work in
this n^2 loop.
         // Instead we should just fix the loop to collect the proper scopes up
the tree instead
         // of iterating all possible scopes.
         const InsertionPoint* insertionPoint = resolveReprojection(element);
-        if ((insertionPoint &&
!scopingNode->containsIncludingShadowDOM(insertionPoint))
-            || (!insertionPoint &&
!scopingNode->containsIncludingShadowDOM(element))) {
+        if ((insertionPoint &&
!scopingHost->containsIncludingShadowDOM(insertionPoint))
+            || (!insertionPoint &&
!scopingHost->containsIncludingShadowDOM(element))) {
             ++innerCascadeOrder;
             --outerCascadeOrder;
             continue;

[kochi, 2014-06-17 03:21:27]

The CQ bit was checked by kochi@chromium.org

[commit-bot: I haz the power, 2014-06-17 03:22:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kochi@chromium.org/313303002/40001

[kochi, 2014-06-17 04:59:10]

The CQ bit was unchecked by kochi@chromium.org

[kochi, 2014-06-17 08:43:48]

The CQ bit was checked by kochi@chromium.org

[commit-bot: I haz the power, 2014-06-17 08:44:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kochi@chromium.org/313303002/60001

[commit-bot: I haz the power, 2014-06-17 10:28:54]

Change committed as 176304