Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 313273004: Make test apks only dex files not in tested apk (Closed)

Created:
6 years, 6 months ago by cjhopman
Modified:
6 years, 6 months ago
Reviewers:
nyquist
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Make test apks only dex files not in tested apk At runtime, the classloader will look for classes in both apk's dex files. In the standard Android build system, an instrumentation test apk's dex file does not include the classes included in the tested apk's dex file. To do this, when dexing, write a file listing the inputs to the dex file. When dexing for an instrumentation apk, exclude those files listed as inputs of the tested apk's dex file. For proguarded apks, this exclusion will need to happen for proguard inputs instead of dex inputs, so this change does not cover that case. BUG=272790 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -14 lines) Patch
M build/android/dex_action.gypi View 3 chunks +4 lines, -1 line 0 comments Download
M build/android/gyp/dex.py View 3 chunks +10 lines, -3 lines 0 comments Download
M build/java_apk.gypi View 4 chunks +30 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
cjhopman
nyquist: *
6 years, 6 months ago (2014-06-09 18:00:18 UTC) #1
nyquist
lgtm
6 years, 6 months ago (2014-06-10 17:35:42 UTC) #2
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 6 months ago (2014-06-12 17:40:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/313273004/1
6 years, 6 months ago (2014-06-12 17:44:52 UTC) #4
cjhopman
The CQ bit was unchecked by cjhopman@chromium.org
6 years, 6 months ago (2014-06-12 20:22:09 UTC) #5
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 6 months ago (2014-06-12 20:22:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/313273004/1
6 years, 6 months ago (2014-06-12 20:22:49 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 20:28:21 UTC) #8
Message was sent while issue was closed.
Change committed as 276788

Powered by Google App Engine
This is Rietveld 408576698