ServiceWorker: Add UMA for ServiceWorkerDiskCache

ServiceWorker: Add UMA for ServiceWorkerDiskCache


BUG=380973
TEST=n/a

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275668

[nhiroki, 2014-06-05 08:56:21]

Hi, can you take a look? Thanks!

[michaeln, 2014-06-05 22:24:11]

lgtm, is the plan to put other histo loggin methods in there too?

https://codereview.chromium.org/313273003/diff/40001/content/browser/service_...
File content/browser/service_worker/service_worker_histograms.h (right):

https://codereview.chromium.org/313273003/diff/40001/content/browser/service_...
content/browser/service_worker/service_worker_histograms.h:16: enum
ReadResponseResult {
nit: style guide says to put enums before methods

[nhiroki, 2014-06-05 23:55:07]

Thank you!

On 2014/06/05 22:24:11, michaeln wrote:
> lgtm, is the plan to put other histo loggin methods in there too?

Yes, it is. Regarding storage related histograms, I think it might be useful to
record...
- the number of stored registrations, resources, unique origins
- the number of attempts of corruption recovery
- etc...

https://codereview.chromium.org/313273003/diff/40001/content/browser/service_...
File content/browser/service_worker/service_worker_histograms.h (right):

https://codereview.chromium.org/313273003/diff/40001/content/browser/service_...
content/browser/service_worker/service_worker_histograms.h:16: enum
ReadResponseResult {
On 2014/06/05 22:24:10, michaeln wrote:
> nit: style guide says to put enums before methods

Done.

[nhiroki, 2014-06-05 23:58:09]

+asvitkine@, could you review histograms.xml?

[Alexei Svitkine (slow), 2014-06-06 15:07:57]

lgtm

[nhiroki, 2014-06-07 03:24:45]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2014-06-07 03:27:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nhiroki@chromium.org/313273003/80001

[commit-bot: I haz the power, 2014-06-07 09:13:07]

Change committed as 275668