Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 313263004: Revert of Enable touch text selection by default on desktop Aura (Closed)

Created:
6 years, 6 months ago by Peter Beverloo
Modified:
6 years, 6 months ago
Reviewers:
sky, mohsen
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Enable touch text selection by default on desktop Aura (https://codereview.chromium.org/305423003/) Reason for revert: This change has broken two Blink layout-tests, context-menu-on-long-press.html and right-click-gestures-set-cursor-at-correct-position.html. More relevant information, failed runs and output is available in the bug. BUG=381152 Original issue's description: > Enable touch text selection by default on desktop Aura > > --disable-touch-editing can be used to disable touch text selection. > > BUG=304872 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274972 TBR=sky@chromium.org,mohsen@chromium.org NOTREECHECKS=true NOTRY=true BUG=304872 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275138

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ui_base_switches_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Peter Beverloo
Created Revert of Enable touch text selection by default on desktop Aura
6 years, 6 months ago (2014-06-05 13:48:48 UTC) #1
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 6 months ago (2014-06-05 13:50:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/313263004/1
6 years, 6 months ago (2014-06-05 13:53:05 UTC) #3
Peter Beverloo
The CQ bit was unchecked by peter@chromium.org
6 years, 6 months ago (2014-06-05 15:37:13 UTC) #4
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 6 months ago (2014-06-05 15:37:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/313263004/1
6 years, 6 months ago (2014-06-05 15:38:20 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 15:39:52 UTC) #7
Message was sent while issue was closed.
Change committed as 275138

Powered by Google App Engine
This is Rietveld 408576698