Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Issue 313263003: [CSS Grid Layout] Add test coverage for Implicit Named Areas (Closed)

Created:
6 years, 6 months ago by svillar
Modified:
6 years, 6 months ago
CC:
blink-reviews, jfernandez, Manuel Rego
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Grid Layout] Add test coverage for Implicit Named Areas Specs state in section 5.2.2 that explicitly adding named lines of the form <foo-start>/<foo-end> should effectively create a named grid area (named foo in this case). We got this for free in r174021 as a nice side effect of implementing the resolution for named grid lines. We just lack proper test coverage to ensure that we don't regress. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176300

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html View 2 chunks +14 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
svillar
Adding reviewers as this was in unsent state
6 years, 6 months ago (2014-06-10 10:15:19 UTC) #1
ojan
6 years, 6 months ago (2014-06-10 17:20:48 UTC) #2
svillar
On 2014/06/10 17:20:48, ojan wrote: ping
6 years, 6 months ago (2014-06-16 11:28:33 UTC) #3
Julien - ping for review
Aren't you missing BUG=? lgtm
6 years, 6 months ago (2014-06-16 20:37:39 UTC) #4
svillar
The CQ bit was checked by svillar@igalia.com
6 years, 6 months ago (2014-06-17 08:12:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svillar@igalia.com/313263003/1
6 years, 6 months ago (2014-06-17 08:12:36 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 09:20:17 UTC) #7
Message was sent while issue was closed.
Change committed as 176300

Powered by Google App Engine
This is Rietveld 408576698