Issue 313233004: Remove RenderViewImpl::device_orientation_dispatcher_ (not used).

Issue 313233004: Remove RenderViewImpl::device_orientation_dispatcher_ (not used). (Closed)

Created:
6 years, 6 months ago by mlamouri (slow - plz ping)

Modified:
6 years, 6 months ago

Reviewers:
jamesr, jochen (gone - plz use gerrit), Michael van Ouwerkerk

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove RenderViewImpl::device_orientation_dispatcher_ (not used). BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275483

Patch Set 2 : remove fwd decl #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	content/renderer/render_view_impl.h	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

mlamouri (slow - plz ping)

jamesr@, can you have a look at that. Should be straightforward ;)

6 years, 6 months ago (2014-06-06 09:09:46 UTC) #1

Michael van Ouwerkerk

Drive-by nit. Woosh! https://codereview.chromium.org/313233004/diff/1/content/renderer/render_view_impl.h File content/renderer/render_view_impl.h (left): https://codereview.chromium.org/313233004/diff/1/content/renderer/render_view_impl.h#oldcode130 content/renderer/render_view_impl.h:130: class DeviceOrientationDispatcher; Nit: should also clean ...

6 years, 6 months ago (2014-06-06 09:41:54 UTC) #2

mlamouri (slow - plz ping)

Adding jochen as reviewer. I've heard he is still responsive for review even though he ...

6 years, 6 months ago (2014-06-06 09:50:53 UTC) #3

mlamouri (slow - plz ping)

The CQ bit was checked by mlamouri@chromium.org

6 years, 6 months ago (2014-06-06 13:06:30 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/313233004/20001

6 years, 6 months ago (2014-06-06 13:07:07 UTC) #6

Message was sent while issue was closed.

Change committed as 275483

Expand Messages | Collapse Messages