Source/core/rendering/InlineTextBox.h - Issue 313233002: Adding backgroundColor to WebCompositionUnderline and using it for InlineTextBox drawing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/InlineTextBox.h

Issue 313233002: Adding backgroundColor to WebCompositionUnderline and using it for InlineTextBox drawing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Renaming to CompositionUnderlineRangeFilter and using .begin(), .end(); adding unit test. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/editing/CompositionUnderlineRangeFilter.cpp ('K') | « Source/core/editing/CompositionUnderlineRangeFilterTest.cpp ('k') | Source/core/rendering/InlineTextBox.cpp » ('j') | Source/core/rendering/InlineTextBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/InlineTextBox.h

diff --git a/Source/core/rendering/InlineTextBox.h b/Source/core/rendering/InlineTextBox.h

index e2db766e70651e7a02db6eeb35644edb2025e861..bdd38ec1b13fddb01eca64e22ca4170f08d24881 100644

--- a/Source/core/rendering/InlineTextBox.h

+++ b/Source/core/rendering/InlineTextBox.h

@@ -174,9 +174,12 @@ private:

unsigned short m_truncation; // Where to truncate when text overflow is applied. We use special constants to

// denote no truncation (the whole run paints) and full truncation (nothing paints at all).

+private:

+ unsigned getUnderlinePaintStart(const CompositionUnderline&);

yosin_UTC9 2014/06/09 01:49:56 nit: Blink doesn't use "get" prefix for getter. Ju

huangs 2014/06/09 06:07:13 Done.

+ unsigned getUnderlinePaintEnd(const CompositionUnderline&);

protected:

- void paintCompositionBackground(GraphicsContext*, const FloatPoint& boxOrigin, RenderStyle*, const Font&, int startPos, int endPos);

+ void paintCompositionBackground(GraphicsContext*, const FloatPoint& boxOrigin, RenderStyle*, const Font&, Color backgroundColor, int startPos, int endPos);

void paintDocumentMarkers(GraphicsContext*, const FloatPoint& boxOrigin, RenderStyle*, const Font&, bool background);

void paintCompositionUnderline(GraphicsContext*, const FloatPoint& boxOrigin, const CompositionUnderline&);