Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: Source/core/editing/CompositionUnderline.h

Issue 313233002: Adding backgroundColor to WebCompositionUnderline and using it for InlineTextBox drawing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/CompositionUnderline.h
diff --git a/Source/core/editing/CompositionUnderline.h b/Source/core/editing/CompositionUnderline.h
index 025ee75cbf7696170769d5531c0891a254fb2681..d093469d4152e1b22c07f9252a5941d3b3c481a5 100644
--- a/Source/core/editing/CompositionUnderline.h
+++ b/Source/core/editing/CompositionUnderline.h
@@ -32,13 +32,32 @@ namespace WebCore {
struct CompositionUnderline {
CompositionUnderline()
- : startOffset(0), endOffset(0), thick(false) { }
+ : startOffset(0)
+ , endOffset(0)
+ , color(0)
+ , thick(false)
+ , backgroundColor(0) { }
+
+ // TODO(huangs): remove this constructor.
CompositionUnderline(unsigned s, unsigned e, const Color& c, bool t)
- : startOffset(s), endOffset(e), color(c), thick(t) { }
+ : startOffset(s)
+ , endOffset(e)
+ , color(c)
+ , thick(t)
+ , backgroundColor(0) { }
+
+ CompositionUnderline(unsigned s, unsigned e, const Color& c, bool t, const Color& bc)
+ : startOffset(s)
+ , endOffset(e)
+ , color(c)
+ , thick(t)
+ , backgroundColor(bc) { }
+
unsigned startOffset;
unsigned endOffset;
Color color;
bool thick;
+ Color backgroundColor;
};
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698