Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(41)

Issue 313213002: Revert 258215 "Remove muting for extreme playbackRates." (Closed)

Created:
4 years, 9 months ago by scherkus (not reviewing)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Revert 258215 "Remove muting for extreme playbackRates." It exposed a bug in the WSOLA algorithm that causes it to incorrectly trigger underflows. > Remove muting for extreme playbackRates. > > Audio was muted below 0.5x and above 4x as the quality degraded > significantly under the crossfade algorithm. The quality is now much > better under the WSLOA algorithm (r220343). > > BUG=289354 > R=scherkus@chromium.org > R=dalecurtis@chromium.org > > Review URL: https://codereview.chromium.org/205093002 BUG=368083 TBR=sandersd@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -1 line) Patch
M media/filters/audio_renderer_algorithm.h View 3 chunks +11 lines, -0 lines 0 comments Download
M media/filters/audio_renderer_algorithm.cc View 4 chunks +35 lines, -0 lines 0 comments Download
M media/filters/audio_renderer_algorithm_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
scherkus (not reviewing)
4 years, 9 months ago (2014-06-04 21:05:28 UTC) #1
scherkus (not reviewing)
4 years, 9 months ago (2014-06-04 21:05:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r274903.

Powered by Google App Engine
This is Rietveld 408576698