Issue 313213002: Revert 258215 "Remove muting for extreme playbackRates."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 313213002: Revert 258215 "Remove muting for extreme playbackRates." (Closed)

Created:
6 years, 6 months ago by scherkus (not reviewing)

Modified:
6 years, 6 months ago

Reviewers:
sandersd (OOO until July 31)

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1985/src/

Visibility:
Public.

Revert 258215 "Remove muting for extreme playbackRates." It exposed a bug in the WSOLA algorithm that causes it to incorrectly trigger underflows. > Remove muting for extreme playbackRates. > > Audio was muted below 0.5x and above 4x as the quality degraded > significantly under the crossfade algorithm. The quality is now much > better under the WSLOA algorithm (r220343). > > BUG=289354 > R=scherkus@chromium.org > R=dalecurtis@chromium.org > > Review URL: https://codereview.chromium.org/205093002 BUG=368083 TBR=sandersd@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274903

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -1 line)			Patch
M	media/filters/audio_renderer_algorithm.h	View	3 chunks	+11 lines, -0 lines	0 comments	Download
M	media/filters/audio_renderer_algorithm.cc	View	4 chunks	+35 lines, -0 lines	0 comments	Download
M	media/filters/audio_renderer_algorithm_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

scherkus (not reviewing)

6 years, 6 months ago (2014-06-04 21:05:59 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r274903.